Integrate passive disconnect handling and automatic reconnect functionality #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikolomi
force-pushed
the
detect_disconnects
branch
from
94ed8c4
to
612d2f7
Compare
ikolomi
force-pushed
the
detect_disconnects
branch
from
612d2f7
to
6609d69
Compare
ikolomi
force-pushed
the
detect_disconnects
branch
from
6609d69
to
4561923
Compare
ikolomi
force-pushed
the
detect_disconnects
branch
from
4561923
to
0a11f57
Compare
| // as improper configuration could negatively impact performance or pub/sub resiliency. | ||
| // A 3-second interval provides a reasonable balance between connection validation | ||
| // and performance overhead. | ||
| pub const CONNECTION_CHECKS_INTERVAL: Duration = Duration::from_secs(3); |
There was a problem hiding this comment.
Do you have benchmarking results to confirm that?
submodules/redis-rs
Outdated
There was a problem hiding this comment.
Changes from submodule should be listed and described in the PR
ikolomi
force-pushed
the
detect_disconnects
branch
from
0a11f57
to
293a345
Compare
ikolomi
force-pushed
the
detect_disconnects
branch
from
293a345
to
38a3171
Compare
eifrah-aws
reviewed
Sep 12, 2024
…nality. Maintaining a continuous connection to the server(s) is crucial, especially in PubSub contexts, where undetected disconnects can render the listener inoperable. Additionally, immediately attempting to reestablish a closed connection reduces latency for the next command. This functionality is implemented differently for standalone and cluster modes: - In standalone mode, it utilizes the reconnect functionality, triggered immediately upon detecting a disconnect, without waiting for the next command. - In cluster mode, it relies on the changes introduced in amazon-contributing/redis-rs@2c7faec. The validation processes are lightweight in terms of performance and run every 3 seconds. Signed-off-by: ikolomi <ikolomin@amazon.com>
ikolomi
force-pushed
the
detect_disconnects
branch
from
38a3171
to
68c6b3b
Compare
ikolomi
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
eifrah-aws
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining a continuous connection to the server(s) is crucial, especially in PubSub contexts, where undetected disconnects can render the listener inoperable.
Additionally, immediately attempting to reestablish a closed connection reduces latency for the next command.
This functionality is implemented differently for standalone and cluster modes:
The validation processes are lightweight in terms of performance and run every 3 seconds.