Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Expanded tests for converting non UTF-8 bytes to Strings #2286

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Java: Expanded tests for converting non UTF-8 bytes to Strings #2286

merged 6 commits into from
Sep 13, 2024

Conversation

GumpacG
Copy link
Collaborator

@GumpacG GumpacG commented Sep 12, 2024

Expands on testing for #2271.

Tests were included for stream, sorted set, list, and geospatial data types.
Also specified ? type to double for convertMapToValueKeyStringArray's parameter. This function affects

CompletableFuture<Long> zadd(
            @NonNull String key,
            @NonNull Map<String, Double> membersScoresMap,
            @NonNull ZAddOptions options,
            boolean changed)

acarbonetto
acarbonetto approved these changes Sep 12, 2024
View reviewed changes
java/client/src/main/java/glide/utils/ArrayTransformUtils.java
* @return Array of strings [value1.toString(), key1, value2.toString(), key2, ...].
*/
public static String[] convertMapToValueKeyStringArray(Map<String, ?> args) {
public static String[] convertMapToValueKeyStringArray(Map<String, Double> args) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@GumpacG GumpacG added the java issues and fixes related to the java client label Sep 12, 2024
@GumpacG GumpacG marked this pull request as ready for review September 13, 2024 13:33
@GumpacG GumpacG requested a review from a team as a code owner September 13, 2024 13:33
@GumpacG
Added tests for xadd, lmpop, geoadd, and zadd
008f73c 
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG
Added Changelog entry
bf30d0b 
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG
Applied Spotless
574f7e6 
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG
Added new keys for tests
2cdcc9a 
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@acarbonetto acarbonetto merged commit 4cf70d2 into valkey-io:main Sep 13, 2024
41 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/expand_bytes_testing branch September 13, 2024 20:05
@acarbonetto acarbonetto mentioned this pull request Sep 14, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@acarbonetto acarbonetto acarbonetto approved these changes

Assignees
No one assigned
Labels
java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GumpacG @Yury-Fridlyand @acarbonetto