Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: fix CD #2302

Merged
merged 11 commits into from
Sep 18, 2024
Merged

Python: fix CD #2302

merged 11 commits into from
Sep 18, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

Python 3.8 is deprecated already.

This fixes the following error in CD pipeline:

💥 maturin failed
  Caused by: The given list of python interpreters is invalid
  Caused by: Python interpreter `python3.8` doesn't exist
Error: The process '/Users/runner/work/_temp/a5716052-c497-4ed1-a668-dbf74ad367a6/maturin' failed with exit code 1

https://github.com/valkey-io/valkey-glide/actions/runs/10871422062/job/30197251230#step:14:43

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added python Python wrapper CI/CD CI/CD related labels Sep 16, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner September 16, 2024 22:12
@Yury-Fridlyand
Copy link
Collaborator Author

Yury-Fridlyand commented Sep 17, 2024

Converted to draft to avoid a merge before CI issue resolved.
It is not confirmed yet that we can remove support for python 3.8.

@Yury-Fridlyand Yury-Fridlyand added the Release blocker Can't release without. label Sep 17, 2024
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand marked this pull request as ready for review September 18, 2024 15:42
@ikolomi ikolomi self-requested a review September 18, 2024 15:45
@ikolomi ikolomi merged commit 59cfa7f into release-1.1 Sep 18, 2024
60 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the python/yuryf-fix-cd branch September 18, 2024 15:56
acarbonetto pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Sep 19, 2024
* Fix python CD

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Install python 3.8

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
acarbonetto pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Sep 19, 2024
* Fix python CD

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Install python 3.8

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD related python Python wrapper Release blocker Can't release without.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: CD fails due to python 3.8 deprecation
5 participants