Improve retry semantics #2330
Closed
Improve retry semantics #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikolomi
added
Rust core
Core changes
eifrah-aws
approved these changes
Sep 19, 2024
|
You're missing DCO. |
Yury-Fridlyand
requested changes
Sep 19, 2024
asafpamzn
reviewed
Sep 22, 2024
asafpamzn
reviewed
Sep 22, 2024
asafpamzn
approved these changes
Sep 22, 2024
ikolomi
force-pushed
the
improve_retry_semantics
branch
from
6f07ac8
to
3d06615
Compare
|
@Yury-Fridlyand change log added |
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Replace google-api-python-client with protobuf Signed-off-by: Raphaël Vinot <raphael@vinot.info>
Signed-off-by: ort-bot <valkey-glide@lists.valkey.io>
* Go: Handling generic arrays instead of only string arrays Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
…tandalone. (#2303) * Go:Implement generic map handler and config get,set for standalone. Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
ikolomi
force-pushed
the
improve_retry_semantics
branch
from
3d06615
to
2f64b79
Compare
a. Absence of command retry configuration in client creation params making retry mechanics unexpected, confusing and inconsistent with command timeout constrains. b. Retry semantics are inconsistent between the CME and CMD client since CMD lacks the retry logic Signed-off-by: ikolomi <ikolomin@amazon.com>
ikolomi
force-pushed
the
improve_retry_semantics
branch
from
2f64b79
to
70a9065
Compare
ikolomi
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a. Absence of command retry configuration in client creation params making retry mechanics unexpected, confusing and
inconsistent with command timeout constrains.
b. Retry semantics are inconsistent between the CME and CMD client since CMD lacks the retry logic
Issue: #2251