Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Minor fixes #2333

Merged
merged 1 commit into from
Oct 28, 2024
Merged

CI: Minor fixes #2333

merged 1 commit into from
Oct 28, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Sep 19, 2024 •
edited
Loading

Add GH token where it was expected and remove where it wasn't.

  1. Removes following errors from CI:
    1. https://github.com/valkey-io/valkey-glide/actions/runs/10941314385/job/30390901801?pr=2330#step:3:326 (missing token)
    2. https://github.com/valkey-io/valkey-glide/actions/runs/10945889521/job/30391119685#step:3:283 (unexpected token)
  2. Add CI trigger for release branches

@Yury-Fridlyand Yury-Fridlyand added the CI/CD CI/CD related label Sep 19, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner September 19, 2024 17:38
@Yury-Fridlyand
Update CI
3423cb7 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand changed the base branch from main to release-1.2 October 23, 2024 02:48
@Yury-Fridlyand Yury-Fridlyand merged commit 5cf72b1 into valkey-io:release-1.2 Oct 28, 2024
1 check passed
@Yury-Fridlyand Yury-Fridlyand deleted the ci/yuryf-minor-fixes branch October 28, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarbonetto acarbonetto acarbonetto approved these changes

@avifenesh avifenesh avifenesh approved these changes

Assignees
No one assigned
Labels
CI/CD CI/CD related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yury-Fridlyand @avifenesh @acarbonetto