Java; Fix IT #2350
Merged
Java; Fix IT #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Yury-Fridlyand
commented
Sep 24, 2024
•
Yury-Fridlyand
commented
- Fix flaky IT
- Activate that test with valkey 8
- Uncomment a test
Yury-Fridlyand
added
java
acarbonetto
approved these changes
Sep 26, 2024
| // function $funcName returns array with first two arguments | ||
| String code = | ||
| generateLuaLibCode(libName, Map.of(funcName.toString(), "return {keys[1], keys[2]}"), true); | ||
| generateLuaLibCode(libName, Map.of(funcName.toString(), "return {args[1]}"), true); |
There was a problem hiding this comment.
please rename the test if we are no longer passing in keys
There was a problem hiding this comment.
We pass it, but don't use it
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
eifrah-aws
reviewed
Oct 2, 2024
prateek-kumar-improving
approved these changes
Oct 7, 2024
prateek-kumar-improving
pushed a commit
that referenced
this pull request
Oct 8, 2024
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.