Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: add node cluster mode and standalone examples #2357

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

adarovadya
Copy link
Collaborator

No description provided.

@adarovadya adarovadya requested a review from a team as a code owner September 26, 2024 12:56
@Yury-Fridlyand Yury-Fridlyand added node Node.js wrapper docs Documentation labels Sep 26, 2024
examples/node/cluster_example.ts Show resolved Hide resolved
const infoReplResps = await client.info({
sections: [InfoOptions.Replication],
});
const infoReplicationValues = Object.values(infoReplResps);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell why you're getting these values

examples/node/standalone_example.ts Outdated Show resolved Hide resolved
examples/node/cluster_example.ts Show resolved Hide resolved
examples/node/cluster_example.ts Show resolved Hide resolved
@ikolomi ikolomi self-requested a review September 29, 2024 06:07
examples/python/cluster_example.py Show resolved Hide resolved
package.json Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier change

examples/node/cluster_example.ts Show resolved Hide resolved
examples/node/cluster_example.ts Show resolved Hide resolved
examples/node/cluster_example.ts Show resolved Hide resolved
examples/node/cluster_example.ts Outdated Show resolved Hide resolved
examples/node/standalone_example.ts Outdated Show resolved Hide resolved
examples/node/standalone_example.ts Outdated Show resolved Hide resolved
Adar Ovadia added 2 commits September 29, 2024 07:51
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Signed-off-by: Adar Ovadia <adarov@amazon.com>
@adarovadya adarovadya merged commit 2510ab9 into valkey-io:main Sep 29, 2024
8 checks passed
umit pushed a commit to umit/valkey-glide that referenced this pull request Oct 1, 2024
* Node: add node cluster mode example

Signed-off-by: Adar Ovadia <adarov@amazon.com>

---------

Signed-off-by: Adar Ovadia <adarov@amazon.com>
Co-authored-by: Adar Ovadia <adarov@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation node Node.js wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants