Python initial vss commands #2358
Open
+141
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
|
please take a look at this pr: It follows the original design and was nearly complete. It's up for discussion, but I suggest we stick to this design. 🙂 |
shohamazon
reviewed
Sep 29, 2024
| ) -> TOK: | ||
| args: List[TEncodable] = [indexName] | ||
| args.extend(options.getCreateOptions()) | ||
| return cast(TOK, await client._execute_command(RequestType.FtCreate, args)) |
There was a problem hiding this comment.
take a look at the implemented json commands, we use custom_command :)
There was a problem hiding this comment.
the reason is that when you will implement the same command in node/ java , you wont be able to use _execute_command without changing it to be public
shohamazon
reviewed
Sep 29, 2024
| @@ -0,0 +1,21 @@ | |||
| from typing import List, cast | |||
There was a problem hiding this comment.
not sure if we want to name this file vss, search.py might be a better name
shohamazon
reviewed
Sep 29, 2024
| client: TGlideClient, | ||
| indexName: TEncodable, | ||
| options: FtCreateOptions | ||
| ) -> TOK: |
shohamazon
requested changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.