Go: Implementing Copy command #2480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMwita
force-pushed
the
implement-copy-command
branch
3 times, most recently
from
42b3dd4
to
62ebad6
Compare
Signed-off-by: MikeMwita <mwitamike8@gmail.com>
MikeMwita
force-pushed
the
implement-copy-command
branch
from
62ebad6
to
eec17bc
Compare
avifenesh
requested review from
Yury-Fridlyand,
janhavigupta007 and
eifrah-aws
janhavigupta007
requested changes
Nov 4, 2024
| @@ -744,3 +744,22 @@ func (client *baseClient) Del(keys []string) (Result[int64], error) { | |||
|
|
|||
| return handleLongResponse(result) | |||
| } | |||
|
|
|||
| func (client *baseClient) Copy(sourceKey, destinationKey string, destinationDB *int, replace bool) (Result[bool], error) { | |||
There was a problem hiding this comment.
Behavior of Copy is different for standalone and cluster mode. Can we please keep the definition of commands consistent with other clients? Reference
GenericBaseCommands:
Copy(source, destination)
Copy(source, destination, replace)
GenericCommands:
Copy(source, destination, destinationDB)
Copy(source, destination, destinationDB, replace)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.