Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: FT.AGGREGATE #2554

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Node: FT.AGGREGATE #2554

merged 5 commits into from
Nov 7, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Oct 31, 2024

Issue link

#2527

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
node/src/server-modules/GlideFtOptions.ts Outdated Show resolved Hide resolved
node/src/server-modules/GlideFtOptions.ts Outdated Show resolved Hide resolved
node/src/server-modules/GlideFtOptions.ts Outdated Show resolved Hide resolved
},
]);

// FT.CREATE idx:movie ON hash PREFIX 1 "movie:" SCHEMA title TEXT release_year NUMERIC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate test?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I split in java too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a separate test in Python.

node/tests/ServerModules.test.ts Show resolved Hide resolved
node/src/server-modules/GlideFt.ts Outdated Show resolved Hide resolved
node/src/server-modules/GlideFt.ts Outdated Show resolved Hide resolved
node/src/server-modules/GlideFt.ts Outdated Show resolved Hide resolved
node/src/server-modules/GlideFt.ts Outdated Show resolved Hide resolved
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…alkey-419-aggreg

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@acarbonetto acarbonetto mentioned this pull request Nov 6, 2024
6 tasks
@acarbonetto acarbonetto merged commit 204364c into release-1.2 Nov 7, 2024
16 checks passed
@acarbonetto acarbonetto deleted the node/yuryf-valkey-419-aggreg branch November 7, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants