Bump valkey 8 wait timeout #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
acarbonetto
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
shohamazon
reviewed
Nov 5, 2024
| @@ -32,7 +32,7 @@ | |||
| import org.junit.jupiter.params.provider.Arguments; | |||
| import org.junit.jupiter.params.provider.MethodSource; | |||
|
|
|||
| @Timeout(25) // seconds | |||
| @Timeout(35) // seconds | |||
There was a problem hiding this comment.
SharedClientTests > inflight requests limit (boolean, int) > [3] false, 1000 STARTED
glide.SharedClientTests.inflight_requests_limit(boolean, int)[3]: SUCCESS 22.903s
This is needed since it failed on 25 seconds and when i ran in locally on arm its pretty slow
There was a problem hiding this comment.
Please increase timeout for one test only. BTW why it runs too long? Aren't we hiding a real issue by increasing the timeout?
acarbonetto
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
acarbonetto
force-pushed
the
java/fix_fcall_tests_valkey8
branch
from
feab083
to
4fd6361
Compare
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
acarbonetto
force-pushed
the
java/fix_fcall_tests_valkey8
branch
from
4fd6361
to
7027b28
Compare
acarbonetto
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
acarbonetto
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
avifenesh
approved these changes
Nov 6, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): Fixes #2619 and #2618
Raised Timeouts to add flexibility on some tests and avoid time outs for tests:
glide.SharedClientTests.send_and_receive_large_valuesglide.cluster.CommandTests.fcall_readonly_functionFixes CI run: https://github.com/valkey-io/valkey-glide/actions/runs/11691408118 (note: modules test was rejected - hence the red 'X')
Checklist
Before submitting the PR make sure the following are checked: