Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Add FT._ALIASLIST command #2652

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Node: Add FT._ALIASLIST command #2652

merged 4 commits into from
Nov 8, 2024

Conversation

prateek-kumar-improving
Copy link
Collaborator

@prateek-kumar-improving prateek-kumar-improving commented Nov 8, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #2527

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.
Screenshot 2024-11-08 at 3 54 05 PM

@prateek-kumar-improving
Node: Add FT._ALIASLIST command
f4a1abf 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving prateek-kumar-improving requested a review from a team as a code owner November 8, 2024 21:53
@prateek-kumar-improving
Node: FT._ALIASLIST command CHANGELOG.md file updated
edfb719 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving prateek-kumar-improving added the node Node.js wrapper label Nov 8, 2024
Yury-Fridlyand
Yury-Fridlyand approved these changes Nov 8, 2024
View reviewed changes
node/src/server-modules/GlideFt.ts Outdated Show resolved Hide resolved
node/src/server-modules/GlideFt.ts Outdated Show resolved Hide resolved
@prateek-kumar-improving
Node: FT._ALIASLIST formatting fixed
40cbaaf 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Node: FT._ALIASLIST review comments fixed
49eb9b4 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@acarbonetto acarbonetto merged commit 484f581 into release-1.2 Nov 8, 2024
18 checks passed
@acarbonetto acarbonetto deleted the node-ft-alias-list-command branch November 8, 2024 23:55
This was referenced Nov 8, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@jonathanl-bq jonathanl-bq jonathanl-bq approved these changes

@acarbonetto acarbonetto Awaiting requested review from acarbonetto

Assignees
No one assigned
Labels
node Node.js wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prateek-kumar-improving @jonathanl-bq @Yury-Fridlyand @acarbonetto