Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the socket file path in unix systems to /tmp if the user's runtime directory isn't found #298

Merged
merged 2 commits into from
Jul 2, 2023
Merged

Changed the socket file path in unix systems to /tmp if the user's runtime directory isn't found #298

merged 2 commits into from
Jul 2, 2023

Conversation

barshaul
Copy link
Collaborator

@barshaul barshaul commented Jun 29, 2023 •
edited
Loading

Changed the socket file path in unix systems to /tmp if the runtime directory isn't found.
The reason for this change is that the runtime dir isn't found in some basic unix images (such as we use in Polyglot env) and it causes failures:

....thread 'socket_listener_thread' panicked at 'Failed to find the user's runtime folder', /codebuild/output/src3233499915/src/git-codecommit.us-east-1.amazonaws.com/v1/repos/RedisClientsCompatibilityTesting/babushka/babushka-core/src/socket_listener.rs:633:14
516

@barshaul barshaul closed this Jun 29, 2023
@barshaul barshaul reopened this Jun 29, 2023
@barshaul barshaul changed the title Changed the socket file path in unix systems to /var/run Changed the socket file path in unix systems to /tmp if the runtime directory isn't found Jun 29, 2023
@barshaul barshaul changed the title Changed the socket file path in unix systems to /tmp if the runtime directory isn't found Changed the socket file path in unix systems to /tmp if the user's runtime directory isn't found Jun 29, 2023
shachlanAmazon
shachlanAmazon approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@shachlanAmazon shachlanAmazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for this PR - didn't we want to create the socket files inside a sub-directory, in order to reduce pollution of the user's directory?

@barshaul barshaul merged commit ee4a1ff into main Jul 2, 2023
@barshaul barshaul deleted the fix_directory branch July 2, 2023 09:46
acarbonetto added a commit that referenced this pull request May 24, 2024
@Yury-Fridlyand @acarbonetto
Java: Add HSTRLEN command. (#1463)
04cdbe3 
* Java: Add `HSTRLEN` command. (#298)

* Add `HSTRLEN` command.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Update for review comments

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shachlanAmazon shachlanAmazon shachlanAmazon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barshaul @shachlanAmazon