Fixed updating the library version in the CD workflow #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshaul
force-pushed
the
client_version
branch
6 times, most recently
from
b07e427
to
cdb8ca8
Compare
barshaul
force-pushed
the
client_version
branch
from
cdb8ca8
to
365c4ea
Compare
|
Please add a repo check as it was done in #948 for another workflow |
barshaul
force-pushed
the
client_version
branch
from
a08f2ce
to
05d0377
Compare
When changes are done to to verify that it doesn't break the CD |
|
@shachlanAmazon round |
shachlanAmazon
approved these changes
Feb 19, 2024
| @@ -68,25 +69,30 @@ jobs: | |||
| cat Cargo.toml | |||
|
|
|||
| - name: Set up Python | |||
| if: matrix.build.PYPI_PUBLISH == true && !contains(matrix.build.RUNNER, 'self-hosted') | |||
| if: ${{ !contains(matrix.build.RUNNER, 'self-hosted') }} | |||
There was a problem hiding this comment.
minor: why do you need the curly braces here and not in lines 78 / 83?
There was a problem hiding this comment.
The linter gets angry when it's with ! (not) :(
barshaul
force-pushed
the
client_version
branch
2 times, most recently
from
05896e6
to
2b4cb04
Compare
barshaul
force-pushed
the
client_version
branch
from
2b4cb04
to
f742bb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.