Java: Add SELECT() command for standalone
#984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanHalacogluImproving
approved these changes
Feb 16, 2024
java/client/src/main/java/glide/api/commands/ServerManagementCommands.java
Outdated
Show resolved
Hide resolved
acarbonetto
force-pushed
the
java/integ_acarbo_add_select_command
branch
from
07cc8f1
to
9089494
Compare
shohamazon
reviewed
Feb 18, 2024
shohamazon
reviewed
Feb 18, 2024
java/client/src/main/java/glide/api/commands/ServerManagementCommands.java
Outdated
Show resolved
Hide resolved
acarbonetto
force-pushed
the
java/integ_acarbo_add_select_command
branch
from
f4e33e0
to
d8670de
Compare
Yury-Fridlyand
approved these changes
Feb 21, 2024
barshaul
reviewed
Feb 21, 2024
| @@ -54,4 +55,10 @@ public CompletableFuture<String> info() { | |||
| public CompletableFuture<String> info(@NonNull InfoOptions options) { | |||
| return commandManager.submitNewCommand(Info, options.toArgs(), this::handleStringResponse); | |||
| } | |||
|
|
|||
| @Override | |||
| public CompletableFuture<String> select(long index) { | |||
There was a problem hiding this comment.
There're only 15 DBs that can be selected, int should be enough :)
barshaul
reviewed
Feb 21, 2024
barshaul
reviewed
Feb 21, 2024
java/client/src/test/java/glide/api/models/TransactionTests.java
Outdated
Show resolved
Hide resolved
barshaul
approved these changes
Feb 21, 2024
shohamazon
approved these changes
Feb 22, 2024
shohamazon
reviewed
Feb 22, 2024
* Java: Add SELECT() command for standalone Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Fix IT tests Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
SanHalacogluImproving
force-pushed
the
java/integ_acarbo_add_select_command
branch
from
d8670de
to
b69a1c4
Compare
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Java: Add `SELECT()` command for standalone (#97) * Java: Add SELECT() command for standalone Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Fix IT tests Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Java: Add SADD, SREM, SMEMBERS, and SCARD commands (Set Commands) * Spotless; Doc update Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Doc fixes Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add tests for SELECT() Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless. Added Standalone TransactionTests. --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Co-authored-by: aaron-congo <aaron.congo@improving.com> Co-authored-by: SanHalacogluImproving <san.halacoglu@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add the SELECT() command to the java wrapper.
Example:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.