Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to add spots for a specific origin #2

Open
Alluysl opened this issue Aug 8, 2021 · 4 comments
Open

Add the ability to add spots for a specific origin #2

Alluysl opened this issue Aug 8, 2021 · 4 comments

Comments

@Alluysl
Copy link
Collaborator

Alluysl commented Aug 8, 2021

Essentially, instead of the count of players with any given origin being n or n+1, have it as n to n+i+j+1, with the offsets represented as i and j here being a global offset, and an origin-specific offset respectively, and both queried/specified/modified with a get/set/change command as for resources.
Edit: I have thought about it for longer and came up with a better system. As with what I had imagined as first, it naturally defaults to the current behavior when all the parameters are set to 0.

Edit: adding two three things here:

  • as suggested by Rem_Imaginis on CurseForge, the mod's effects should be able to be turned on/off for specific layers using commands done in PR, next step would be to allow certain players to be immune to the filtering (they should probably still count towards the limits or else that would be a pain to manage).
  • as suggested by SpiderKolo (barman) on CurseForge, a way to "group" origins together so picking one of them counts as picking all of them at once, to make "teams".
  • mixin in other places so using an orb of origins doesn't allow you to pick saturated origins and shows the random origins that are actually available and not the saturated ones as well.

Besides being able to set offsets from resources/scoreboards I don't think the mod can get more customizable than this without putting a lot of work into it.

By the way good luck with your worldgen mod, which is I believe what you're busy with at the moment.

@Alluysl
Copy link
Collaborator Author

Alluysl commented Aug 9, 2021

The repo description wasn't lying

@Alluysl
Copy link
Collaborator Author

Alluysl commented Aug 10, 2021

Can you add me on Discord actually? I tried friending you but you don't accept requests. I thoroughly examined the logic the mod currently uses and have two ideas regarding the way to implement this (and a spreadsheet to prove that both algorithms work) and I wish not to force a design decision upon a mod that's still very much yours.

@Alluysl Alluysl changed the title When eventually updating to 1.17, add the ability to add spots for a specific origin Add the ability to add spots for a specific origin Aug 11, 2021
@valoeghese
Copy link
Owner

valoeghese commented Aug 22, 2021

Can you add me on Discord actually? I tried friending you but you don't accept requests. I thoroughly examined the logic the mod currently uses and have two ideas regarding the way to implement this (and a spreadsheet to prove that both algorithms work) and I wish not to force a design decision upon a mod that's still very much yours.

https://discord.gg/ecpxmjt

If you want I can transfer the mod to you btw. You'd probably manage it better than me, I end up being too busy most of the year to work on all my mods, to the point where I've basically dropped active support and development for all but a couple mods

@Alluysl
Copy link
Collaborator Author

Alluysl commented Sep 3, 2021

Writing this as a reminder to myself to investigate why the error doesn't send the proper feedback.
Edit: found out why, it does send proper feedback as long as it doesn't encounter another error which seems out of control of the mod (except for writing a custom, fixed version of it for use in this mod).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants