test(e2e): remove use_tab_navigator override (#5327)

### Description Follow up from #5318. Remove override that is no longer required ### Test plan CI ### Related issues - Part of ACT-1133 ### Backwards compatibility Yes ### Network scalability N/A
valora-inc · Apr 26, 2024 · 0db5dd2 · 0db5dd2
1 parent 52fb14d
commit 0db5dd2
Show file tree

Hide file tree

Showing 17 changed files with 6 additions and 81 deletions.
diff --git a/e2e/src/CeloPage.spec.js b/e2e/src/CeloPage.spec.js
@@ -6,11 +6,6 @@ import { launchApp } from './utils/retries'
 
 describe('Celo page', () => {
   beforeAll(async () => {
-    // TODO(ACT-1133): remove launchApp once drawer nav is removed
-    await launchApp({
-      newInstance: true,
-      launchArgs: { statsigGateOverrides: 'use_tab_navigator=true' },
-    })
     await quickOnboarding()
   })
 

diff --git a/e2e/src/Discover.spec.js b/e2e/src/Discover.spec.js
@@ -10,9 +10,6 @@ describe('Discover tab', () => {
     await launchApp({
       newInstance: true,
       permissions: { notifications: 'YES', contacts: 'YES', camera: 'YES' },
-      launchArgs: {
-        statsigGateOverrides: `use_tab_navigator=true`,
-      },
     })
     await waitForElementByIdAndTap('Tab/Discover')
   })

diff --git a/e2e/src/HomeFeed.spec.js b/e2e/src/HomeFeed.spec.js
@@ -8,15 +8,6 @@ beforeAll(async () => {
 
 // iOS only as getAttributes on multiple elements is not supported on Android
 describe(':ios: Home Feed', () => {
-  // TODO(ACT-1133): remove this beforeAll when drawer nav is removed
-  beforeAll(async () => {
-    await launchApp({
-      newInstance: true,
-      permissions: { notifications: 'YES', contacts: 'YES', camera: 'YES' },
-      launchArgs: { statsigGateOverrides: `use_tab_navigator=true` },
-    })
-  })
-
   it('should show correct information on tap of feed item', async () => {
     // Load Wallet Home
     await waitForElementId('WalletHome')

diff --git a/e2e/src/Pin.spec.js b/e2e/src/Pin.spec.js
@@ -10,8 +10,6 @@ describe('Given PIN', () => {
     await launchApp({
       newInstance: true,
       permissions: { notifications: 'YES', contacts: 'YES' },
-      // TODO(ACT-1133): remove launchArgs
-      launchArgs: { statsigGateOverrides: `use_tab_navigator=true` },
     })
     await quickOnboarding()
   })

diff --git a/e2e/src/QRScanner.spec.js b/e2e/src/QRScanner.spec.js
@@ -40,14 +40,6 @@ describe(':ios: Given QR Scanner', () => {
   })
 
   describe("When 'scanning' QR", () => {
-    beforeAll(async () => {
-      await launchApp({
-        newInstance: true,
-        permissions: { notifications: 'YES', contacts: 'YES', camera: 'YES' },
-        launchArgs: { statsigGateOverrides: `use_tab_navigator=true` },
-      })
-    })
-
     beforeEach(async () => {
       await reloadReactNative()
       await waitForElementId('HomeAction-Receive')

diff --git a/e2e/src/usecases/Assets.js b/e2e/src/usecases/Assets.js
@@ -75,9 +75,6 @@ export default Assets = () => {
       await launchApp({
         newInstance: true,
         permissions: { notifications: 'YES', contacts: 'YES', camera: 'YES' },
-        launchArgs: {
-          statsigGateOverrides: `use_tab_navigator=true`,
-        },
       })
       let mnemonic = SAMPLE_BACKUP_KEY
       if (balance === 'zero') {

diff --git a/e2e/src/usecases/ChooseYourAdventure.js b/e2e/src/usecases/ChooseYourAdventure.js
@@ -8,7 +8,7 @@ export default ChooseYourAdventure = () => {
     await launchApp({
       newInstance: true,
       launchArgs: {
-        statsigGateOverrides: `use_tab_navigator=true,show_cloud_account_backup_setup=true,show_cloud_account_backup_restore=true`,
+        statsigGateOverrides: `show_cloud_account_backup_setup=true,show_cloud_account_backup_restore=true`,
       },
     })
     await quickOnboarding({ stopOnCYA: true, cloudBackupEnabled: true })

diff --git a/e2e/src/usecases/FiatConnectTransferOut.js b/e2e/src/usecases/FiatConnectTransferOut.js
@@ -189,11 +189,6 @@ export const fiatConnectNonKycTransferOut = () => {
 
 export const fiatConnectKycTransferOut = () => {
   it('FiatConnect cash out', async () => {
-    await launchApp({
-      newInstance: true,
-      permissions: { notifications: 'YES', contacts: 'YES', camera: 'YES' },
-      launchArgs: { statsigGateOverrides: `use_tab_navigator=true` },
-    })
     // ******** First time experience ************
     const cashOutAmount = 0.01
     const gasAmount = 0.015

diff --git a/e2e/src/usecases/NewAccountOnboarding.js b/e2e/src/usecases/NewAccountOnboarding.js
@@ -44,7 +44,7 @@ export default NewAccountOnboarding = () => {
       delete: true,
       permissions: { notifications: 'YES', contacts: 'YES' },
       launchArgs: {
-        statsigGateOverrides: `use_tab_navigator=true,show_cloud_account_backup_setup=true,show_cloud_account_backup_restore=true`,
+        statsigGateOverrides: `show_cloud_account_backup_setup=true,show_cloud_account_backup_restore=true`,
       },
     })
     await sleep(5000)
@@ -159,7 +159,7 @@ export default NewAccountOnboarding = () => {
     await launchApp({
       newInstance: true,
       launchArgs: {
-        statsigGateOverrides: `use_tab_navigator=true,show_cloud_account_backup_setup=true,show_cloud_account_backup_restore=true`,
+        statsigGateOverrides: `show_cloud_account_backup_setup=true,show_cloud_account_backup_restore=true`,
       },
     })
     await quickOnboarding({ mnemonic: testRecoveryPhrase, cloudBackupEnabled: true })

diff --git a/e2e/src/usecases/NewAccountPhoneVerification.js b/e2e/src/usecases/NewAccountPhoneVerification.js
@@ -24,8 +24,6 @@ export default NewAccountPhoneVerification = () => {
     await launchApp({
       delete: true,
       permissions: { notifications: 'YES', contacts: 'YES' },
-      // TODO(ACT-1133): remove launchArgs
-      launchArgs: { statsigGateOverrides: `use_tab_navigator=true` },
     })
 
     // Create new account

diff --git a/e2e/src/usecases/OffRamps.js b/e2e/src/usecases/OffRamps.js
@@ -5,8 +5,6 @@ export default offRamps = () => {
   beforeAll(async () => {
     await launchApp({
       newInstance: true,
-      // TODO(ACT-1133): remove launchArgs
-      launchArgs: { statsigGateOverrides: 'use_tab_navigator=true' },
     })
   })
   beforeEach(async () => {

diff --git a/e2e/src/usecases/OnRamps.js b/e2e/src/usecases/OnRamps.js
@@ -5,8 +5,6 @@ export default onRamps = () => {
   beforeAll(async () => {
     await launchApp({
       newInstance: true,
-      // TODO(AC-1133): remove launchArgs
-      launchArgs: { statsigGateOverrides: `use_tab_navigator=true` },
     })
   })
   beforeEach(async () => {

diff --git a/e2e/src/usecases/ResetAccount.js b/e2e/src/usecases/ResetAccount.js
@@ -1,18 +1,8 @@
 import { SAMPLE_BACKUP_KEY } from '../utils/consts'
-import { reloadReactNative, launchApp } from '../utils/retries'
+import { reloadReactNative } from '../utils/retries'
 import { enterPinUiIfNecessary, navigateToSettings, waitForElementId } from '../utils/utils'
 
 export default ResetAccount = () => {
-  // TODO(ACT-1133): remove this launchApp as it is only needed to update
-  // statsig gate overrides
-  beforeAll(async () => {
-    await launchApp({
-      newInstance: true,
-      permissions: { notifications: 'YES', contacts: 'YES' },
-      launchArgs: { statsigGateOverrides: 'use_tab_navigator=true' },
-    })
-  })
-
   beforeEach(async () => {
     await reloadReactNative()
   })

diff --git a/e2e/src/usecases/RestoreAccountOnboarding.js b/e2e/src/usecases/RestoreAccountOnboarding.js
@@ -19,8 +19,6 @@ export default RestoreAccountOnboarding = () => {
     await device.installApp()
     await launchApp({
       permissions: { notifications: 'YES', contacts: 'YES' },
-      // TODO(ACT-1133): remove launchArgs
-      launchArgs: { statsigGateOverrides: 'use_tab_navigator=true' },
     })
   })
 

diff --git a/e2e/src/usecases/Send.js b/e2e/src/usecases/Send.js
@@ -25,10 +25,7 @@ export default Send = () => {
     let commentText
     beforeAll(async () => {
       commentText = `${new Date().getTime()}-${parseInt(Math.random() * 100000)}`
-      await launchApp({
-        newInstance: true,
-        launchArgs: { statsigGateOverrides: `use_tab_navigator=true` },
-      })
+      await launchApp({ newInstance: true })
     })
 
     it('Then should navigate to send search input from home action', async () => {
@@ -113,10 +110,7 @@ export default Send = () => {
     let commentText
     beforeAll(async () => {
       commentText = `${new Date().getTime()}`
-      await launchApp({
-        newInstance: true,
-        launchArgs: { statsigGateOverrides: `use_tab_navigator=true` },
-      })
+      await launchApp({ newInstance: true })
     })
 
     it('Then should navigate to send search input from home action', async () => {

diff --git a/e2e/src/usecases/Settings.js b/e2e/src/usecases/Settings.js
@@ -4,16 +4,6 @@ import { navigateToSettings, scrollIntoView, sleep, waitForElementByIdAndTap } f
 const faker = require('@faker-js/faker')
 
 export default Settings = () => {
-  // TODO(ACT-1133): remove this launchApp as it is only needed to update
-  // statsig gate overrides
-  beforeAll(async () => {
-    await launchApp({
-      newInstance: true,
-      permissions: { notifications: 'YES', contacts: 'YES' },
-      launchArgs: { statsigGateOverrides: `use_tab_navigator=true` },
-    })
-  })
-
   beforeEach(async () => {
     await reloadReactNative()
     await navigateToSettings()

diff --git a/e2e/src/usecases/Support.js b/e2e/src/usecases/Support.js
@@ -32,12 +32,6 @@ export default Support = () => {
   }
 
   it('Send Message to Support', async () => {
-    // TODO(ACT-1133): remove launchApp
-    await launchApp({
-      newInstance: true,
-      permissions: { notifications: 'YES', contacts: 'YES' },
-      launchArgs: { statsigGateOverrides: `use_tab_navigator=true` },
-    })
     await waitForElementByIdAndTap('WalletHome/AccountCircle')
     await waitForElementByIdAndTap('ProfileMenu/Help')
     await waitFor(element(by.id('SupportContactLink')))