Skip to content

Commit

Permalink
fix(deps): downgrade viem to 1.16.6 to fix send TX serialized as EIP-…
Browse files Browse the repository at this point in the history
…1559 (#4458)

### Description

This reverts commit 3df1888
(#4448).

This is to fix CIP-64 TXs serialized as EIP-1559 when using the
`prepareTransactionRequest` method from viem.
Essentially preventing to pay for TXs using a `feeCurrency`.
This was affecting only the "send with viem" flow as it's the only one
using that method.

We can upgrade again when celo-org/viem#9 lands.

I updated our Renovate rules to ignore `viem` for now.

### Test plan

- Manually tested an account with only cUSD can successfully send TXs.
- Would be good to cover this with an e2e test, but for now I'm only
addressing the immediate issue for the release.

### Related issues

- See Slack
[thread](https://valora-app.slack.com/archives/C04B61SJ6DS/p1699612457370369)

### Backwards compatibility

Yes
  • Loading branch information
jeanregisser committed Nov 10, 2023
1 parent 730aff8 commit 97ff708
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 7 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@
"utf8": "^3.0.0",
"uuid": "^9.0.1",
"victory-native": "^36.6.11",
"viem": "^1.18.9",
"viem": "^1.16.6",
"vm-browserify": "^1.1.2",
"web3": "1.10.3"
},
Expand Down
3 changes: 3 additions & 0 deletions renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,8 @@
'@walletconnect/legacy-types',
'@walletconnect/sign-client',
'@walletconnect/types',
// Temporary until a fix for the CIP-64 serialization bug is released
// See https://github.com/valora-inc/wallet/pull/4458
'viem',
],
}
30 changes: 24 additions & 6 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9168,7 +9168,7 @@ fast-deep-equal@^3.1.1, fast-deep-equal@^3.1.3:
resolved "https://registry.yarnpkg.com/fast-deep-equal/-/fast-deep-equal-3.1.3.tgz#3a7d56b559d6cbc3eb512325244e619a65c6c525"
integrity sha512-f3qQ9oQy9j2AhBe/H9VC91wLmKBCCU/gDOnKNAYG5hswO7BLKj09Hc5HYNz9cGI++xlpDCIgDaitVs03ATR84Q==

fast-glob@^3.2.12, fast-glob@^3.2.9, fast-glob@^3.3.0:
fast-glob@^3.2.12, fast-glob@^3.3.0:
version "3.3.1"
resolved "https://registry.yarnpkg.com/fast-glob/-/fast-glob-3.3.1.tgz#784b4e897340f3dbbef17413b3f11acf03c874c4"
integrity sha512-kNFPyjhh5cKjrUltxs+wFx+ZkbRaxxmZ+X0ZU31SOsxCEtP9VPgtq2teZw1DebupL5GmDaNQ6yKMMVcM41iqDg==
Expand All @@ -9179,6 +9179,17 @@ fast-glob@^3.2.12, fast-glob@^3.2.9, fast-glob@^3.3.0:
merge2 "^1.3.0"
micromatch "^4.0.4"

fast-glob@^3.2.9:
version "3.2.11"
resolved "https://registry.yarnpkg.com/fast-glob/-/fast-glob-3.2.11.tgz#a1172ad95ceb8a16e20caa5c5e56480e5129c1d9"
integrity sha512-xrO3+1bxSo3ZVHAnqzyuewYT6aMFHRAd4Kcs92MAonjwQZLsK9d0SF1IyQ3k5PoirxTW0Oe/RqFgMQ6TcNE5Ew==
dependencies:
"@nodelib/fs.stat" "^2.0.2"
"@nodelib/fs.walk" "^1.2.3"
glob-parent "^5.1.2"
merge2 "^1.3.0"
micromatch "^4.0.4"

fast-json-stable-stringify@2.x, fast-json-stable-stringify@^2.0.0, fast-json-stable-stringify@^2.1.0:
version "2.1.0"
resolved "https://registry.yarnpkg.com/fast-json-stable-stringify/-/fast-json-stable-stringify-2.1.0.tgz#874bf69c6f404c2b5d99c481341399fd55892633"
Expand Down Expand Up @@ -12408,7 +12419,14 @@ makeerror@1.0.12:
dependencies:
tmpl "1.0.5"

map-age-cleaner@^0.1.1, map-age-cleaner@^0.1.3:
map-age-cleaner@^0.1.1:
version "0.1.2"
resolved "https://registry.yarnpkg.com/map-age-cleaner/-/map-age-cleaner-0.1.2.tgz#098fb15538fd3dbe461f12745b0ca8568d4e3f74"
integrity sha512-UN1dNocxQq44IhJyMI4TU8phc2m9BddacHRPRjKGLYaF0jqd3xLz0jS0skpAU9WgYyoR4gHtUpzytNBS385FWQ==
dependencies:
p-defer "^1.0.0"

map-age-cleaner@^0.1.3:
version "0.1.3"
resolved "https://registry.yarnpkg.com/map-age-cleaner/-/map-age-cleaner-0.1.3.tgz#7d583a7306434c055fe474b0f45078e6e1b4b92a"
integrity sha512-bJzx6nMoP6PDLPBFmg7+xRKeFZvFboMrGlxmNj9ClvX53KrmvM5bXFXEWjbz4cz1AFn+jWJ9z/DJSz7hrs0w3w==
Expand Down Expand Up @@ -18270,10 +18288,10 @@ victory@^36.6.11:
victory-voronoi-container "^36.6.11"
victory-zoom-container "^36.6.11"

viem@^1.18.9:
version "1.18.9"
resolved "https://registry.yarnpkg.com/viem/-/viem-1.18.9.tgz#8be8fe3148b1c6c3bccc853001df98f91a8aeb30"
integrity sha512-eAXtoTwAFA3YEgjTYMb5ZTQrDC0UPx5qyZ4sv90TirVKepcM9mBPksTkC1SSWya0UdxhBmhEBL/CiYMjmGCTWg==
viem@^1.16.6:
version "1.16.6"
resolved "https://registry.yarnpkg.com/viem/-/viem-1.16.6.tgz#78118c9269506a59e2bc4deab13f1646e113d3fc"
integrity sha512-jcWcFQ+xzIfDwexwPJRvCuCRJKEkK9iHTStG7mpU5MmuSBpACs4nATBDyXNFtUiyYTFzLlVEwWkt68K0nCSImg==
dependencies:
"@adraffy/ens-normalize" "1.9.4"
"@noble/curves" "1.2.0"
Expand Down

0 comments on commit 97ff708

Please sign in to comment.