fix(earn): ripple on android exceeds border #5395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasbw
approved these changes
May 7, 2024
MuckT
approved these changes
May 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5395 +/- ##
=======================================
Coverage 86.07% 86.07%
=======================================
Files 737 737
Lines 30014 30014
Branches 5143 5143
=======================================
Hits 25835 25835
Misses 3951 3951
Partials 228 228
Continue to review full report in Codecov by Sentry.
|
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description The marginBottom on touchable was causing the ripple to exceed only on the bottom. Wrapped in a View to apply margin ### Test plan | Before | After | |--------|--------| | <video src="https://github.com/valora-inc/wallet/assets/5062591/6b69a921-ab8b-4a8a-8193-a86b228bfa6c" /> | <video src="https://github.com/valora-inc/wallet/assets/5062591/c04e4581-6bf0-484a-800c-97ca9be195f3" /> | ### Related issues - Part of ACT-1174 ### Backwards compatibility Yes ### Network scalability N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The marginBottom on touchable was causing the ripple to exceed only on the bottom. Wrapped in a View to apply margin
Test plan
android-earn-ripple-before.webm
android-earn-ripple-after.webm
Related issues
Backwards compatibility
Yes
Network scalability
N/A