feat(earn): add function for preparing supply transaction #5405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5405 +/- ##
=======================================
Coverage 86.14% 86.15%
=======================================
Files 744 745 +1
Lines 30291 30333 +42
Branches 5181 5186 +5
=======================================
+ Hits 26094 26133 +39
- Misses 3969 3972 +3
Partials 228 228
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
silasbw
approved these changes
May 13, 2024
src/earn/prepareTransactions.ts
Outdated
| // amount in smallest unit | ||
| const amountToSupply = parseUnits(amount, token.decimals) | ||
|
|
||
| if (!token.address) { |
There was a problem hiding this comment.
i've been nagging people to use the viem type guard in places like this:
if (!token.address || !isAddress(token.address) {
src/earn/prepareTransactions.ts
Outdated
| const approvedAllowanceForSpender = await publicClient[ | ||
| networkIdToNetwork[token.networkId] | ||
| ].readContract({ | ||
| address: token.address as Address, |
There was a problem hiding this comment.
...then you can drop the type assertions and maybe feel good about that.
MuckT
reviewed
May 13, 2024
MuckT
reviewed
May 13, 2024
MuckT
reviewed
May 13, 2024
jh2oman
approved these changes
May 13, 2024
MuckT
approved these changes
May 13, 2024
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…#5405) ### Description Mostly based off of swap transaction preparation ### Test plan Unit tests, manually preparing a tx ### Related issues - Part of ACT-1178 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly based off of swap transaction preparation
Test plan
Unit tests, manually preparing a tx
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: