chore: update discover dapp and dapp filter styles #5625
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5625 +/- ##
==========================================
- Coverage 86.72% 86.70% -0.02%
==========================================
Files 773 773
Lines 31567 31562 -5
Branches 5456 5454 -2
==========================================
- Hits 27375 27366 -9
- Misses 3963 3967 +4
Partials 229 229
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| <Touchable | ||
| style={[styles.pressableCard, cardContentContainerStyle]} | ||
| onPress={onPressDapp} | ||
| borderRadius={showBorder ? 8 : undefined} |
There was a problem hiding this comment.
nit: can 8 be Spacing.Smallest8?
There was a problem hiding this comment.
i prefer not to 🙈 i agree that we prefer variables over hardcoded numbers so that we are restricted to certain consistent values + it's easier to make a global change for the values, but i think borders and spaces may not want to use the same variables...it can be a surprise if a change to "Spacing" values also changes rounded corners. i've always wanted to create a separate style enum for borders but never got round to it 😅
Description
Context and design.
This PR only has styles changes. Also fixes the dapp filters appearing on more than 1 row. This PR breaks the dapp rankings styles but that is disabled and earmarked for deletion anyway.
Test plan
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-09.at.12.16.11.mp4
Related issues
n/a
Backwards compatibility
yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: