Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(points): fix "more coming soon" card corners #5627

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

bakoushin
Copy link
Contributor

Description

"More coming soon" card corners aren't rounded.

Context: https://valora-app.slack.com/archives/C0684TXDR3K/p1720545011018399

Issue Fix
image image

Test plan

Visual assessment.

Related issues

Backwards compatibility

Y

Network scalability

NA

@bakoushin bakoushin changed the title fix(points) fix "more coming soon" card corners fix(points): fix "more coming soon" card corners Jul 9, 2024
@bakoushin bakoushin enabled auto-merge July 9, 2024 19:36
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.70%. Comparing base (2e02e91) to head (0304f76).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5627      +/-   ##
==========================================
- Coverage   86.72%   86.70%   -0.02%     
==========================================
  Files         773      773              
  Lines       31567    31567              
  Branches     5456     5456              
==========================================
- Hits        27375    27371       -4     
- Misses       3963     3967       +4     
  Partials      229      229              
Files Coverage Δ
src/points/ActivityCard.tsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e02e91...0304f76. Read the comment docs.

@bakoushin bakoushin added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 7dbe6ee Jul 9, 2024
16 checks passed
@bakoushin bakoushin deleted the alex/fix-more-coming-soon-card-corners branch July 9, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants