Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove support for old escrow invitations flow #5778

Merged
merged 13 commits into from
Aug 16, 2024

Conversation

kathaypacific
Copy link
Collaborator

@kathaypacific kathaypacific commented Aug 15, 2024

Description

This PR removes support for the old escrow flow, where you could send funds to the escrow contract to invite a friend (using their phone number). Specifically, the following is deleted:

  • support for reclaiming sent funds. this includes the UI notification in notification center, as well as all the backend sagas and actions.
  • support for showing invitations via escrow in the homefeed. it's been a long time since we removed escrow so not many users should be impacted by this change. those transactions will be omitted from the feed.

Test plan

Related issues

Backwards compatibility

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Base automatically changed from kathy/jumpstart-viem to main August 15, 2024 15:29
@kathaypacific kathaypacific changed the title chore: remove escrow support chore: remove support for old escrow invitations flow Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (8bb860f) to head (8bcc810).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5778      +/-   ##
==========================================
+ Coverage   86.97%   87.17%   +0.20%     
==========================================
  Files         747      733      -14     
  Lines       31771    31183     -588     
  Branches     5307     5507     +200     
==========================================
- Hits        27632    27183     -449     
+ Misses       4093     3774     -319     
- Partials       46      226     +180     
Files Coverage Δ
src/analytics/Events.tsx 100.00% <ø> (ø)
src/analytics/Properties.tsx 100.00% <ø> (ø)
src/app/ErrorMessages.ts 100.00% <ø> (ø)
src/fees/reducer.ts 73.33% <ø> (-1.67%) ⬇️
src/fees/saga.ts 88.39% <100.00%> (-0.96%) ⬇️
src/home/NotificationBox.tsx 88.65% <ø> (+0.81%) ⬆️
src/home/NotificationCenter.tsx 97.11% <100.00%> (-0.26%) ⬇️
src/home/saga.ts 57.40% <ø> (-1.53%) ⬇️
src/home/types.ts 100.00% <ø> (ø)
src/identity/reducer.ts 29.85% <ø> (ø)
... and 16 more

... and 73 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb860f...8bcc810. Read the comment docs.

@kathaypacific kathaypacific marked this pull request as ready for review August 16, 2024 08:14
Copy link
Contributor

@bakoushin bakoushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Epic cleanup!

@kathaypacific kathaypacific added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit d932c3d Aug 16, 2024
17 checks passed
@kathaypacific kathaypacific deleted the kathy/remove-escrow branch August 16, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants