-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cleanup): Remove show_swap_and_deposit feature gate #6303
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6303 +/- ##
=======================================
Coverage 88.95% 88.95%
=======================================
Files 737 737
Lines 31445 31440 -5
Branches 5833 5831 -2
=======================================
- Hits 27973 27969 -4
+ Misses 3274 3273 -1
Partials 198 198
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -557,34 +553,6 @@ describe('EarnPoolInfoScreen', () => { | |||
expect(getByTestId('Earn/ActionCard/Transfer')).toBeTruthy() | |||
}) | |||
|
|||
it('navigates correctly when swap action item is tapped', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swap action is still possible when the pool doesn't support swap and deposits (e.g., all bridge). Should we retain this test or is there another test that covers this scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh I forgot about that case, I added the test back and modified it so it mimics the allbridge case
Description
Title
Test plan
CI
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: