Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cleanup): Remove show_swap_and_deposit feature gate #6303

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

finnian0826
Copy link
Contributor

Description

Title

Test plan

CI

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • N/A

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (4c5db02) to head (4cc9806).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6303   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files         737      737           
  Lines       31445    31440    -5     
  Branches     5833     5831    -2     
=======================================
- Hits        27973    27969    -4     
+ Misses       3274     3273    -1     
  Partials      198      198           
Files with missing lines Coverage Δ
...c/earn/poolInfoScreen/BeforeDepositBottomSheet.tsx 100.00% <100.00%> (ø)
src/statsig/types.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c5db02...4cc9806. Read the comment docs.

@finnian0826 finnian0826 marked this pull request as ready for review December 5, 2024 21:40
@@ -557,34 +553,6 @@ describe('EarnPoolInfoScreen', () => {
expect(getByTestId('Earn/ActionCard/Transfer')).toBeTruthy()
})

it('navigates correctly when swap action item is tapped', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swap action is still possible when the pool doesn't support swap and deposits (e.g., all bridge). Should we retain this test or is there another test that covers this scenario?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh I forgot about that case, I added the test back and modified it so it mimics the allbridge case

@finnian0826 finnian0826 added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 35133b3 Dec 9, 2024
15 checks passed
@finnian0826 finnian0826 deleted the finnian0826/act-1443-4 branch December 9, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants