Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add getSubtotal #24

Merged
merged 20 commits into from
May 21, 2024
Merged

feat: add getSubtotal #24

merged 20 commits into from
May 21, 2024

Conversation

0xashu
Copy link
Contributor

@0xashu 0xashu commented May 21, 2024 •
edited
Loading

Highlight

  • [Contract] Add getSubtotal
  • [Contract] Fix event params type declaration from uint256 to uint32
  • [Test] Add yieldAggregator test cases
  • [Test] Optimism test coverage from 92.94% to 97.06%
  • [Docs] Update README

@aquariuslt
Copy link
Contributor

aquariuslt commented May 21, 2024 •
edited
Loading

LCOV of commit b7d68bd during coverage #69

Summary coverage rate:
  lines......: 97.1% (167 of 172 lines)
  functions..: 94.1% (48 of 51 functions)
  branches...: 81.7% (49 of 60 branches)

Files changed coverage rate:
                                                    |Lines       |Functions  |Branches    
  Filename                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================
  contracts/core/SharesFactoryV1.sol                | 100%    102|95.0%    20|94.1%     34

@aquariuslt
Copy link
Contributor

Total Coverage: 92.94%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%90.48%100%186, 396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%33

@aquariuslt
Copy link
Contributor

Total Coverage: 92.94%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%90.48%100%186, 396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%33

@aquariuslt
Copy link
Contributor

Total Coverage: 92.94%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%90.48%100%186, 396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%33

@aquariuslt
Copy link
Contributor

Total Coverage: 93.53%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%90.48%100%186, 396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%84.62%74.07%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%33

@aquariuslt
Copy link
Contributor

Total Coverage: 93.53%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%90.48%100%186, 396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%84.62%74.07%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%66.67%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%33

@aquariuslt
Copy link
Contributor

Total Coverage: 93.53%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%90.48%100%186, 396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%84.62%74.07%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%33

@aquariuslt
Copy link
Contributor

Total Coverage: 93.85%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%84.62%74.07%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%33
test
   BaseTest.t.sol100%0%100%

@aquariuslt
Copy link
Contributor

Total Coverage: 93.53%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%84.62%74.07%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%33

@aquariuslt
Copy link
Contributor

Total Coverage: 97.06%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%33

@0xashu 0xashu requested review from aquariuslt and SocratesLu May 21, 2024 08:27
@aquariuslt
Copy link
Contributor

Total Coverage: 97.06%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%33

@aquariuslt
Copy link
Contributor

Total Coverage: 97.06%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 41, 62, 64, 74
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%33

@0xashu 0xashu merged commit d8a7214 into dev May 21, 2024
7 checks passed
@0xashu 0xashu deleted the update/docs branch May 26, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquariuslt aquariuslt aquariuslt approved these changes

@SocratesLu SocratesLu Awaiting requested review from SocratesLu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xashu @aquariuslt