This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
Comprehensive Refactoring of OAuth Components for Concurrency and PKCE Support #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request encompasses a series of refactoring efforts aimed at enhancing the OAuth components. Key changes include:
CodeManager
, ensuring clarity and maintainability.OAuthClient
properties to support Sendable protocol, aligning with Swift's concurrency model.StaticClientRetriever
for safe concurrent access, enhancing performance and reliability in multi-threaded environments.OAuthHelper+remote.swift
, including refactoring of async methods for better asynchronous handling.OAuthFlowType
, further aligning with concurrency requirements.PKCEValidator
for robust Proof Key for Code Exchange (PKCE) validation.generateCode
function and corresponding test methods, enhancing security measures in the code generation process.TokenManager
protocol with new token generation methods, augmenting its functionality.These collective changes are geared towards improving the robustness, security, and maintainability of OAuth implementation, ensuring it meets modern standards of concurrency and security protocols like PKCE.