Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix callbackURL in DiscordRouter #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simjes
Copy link

@simjes simjes commented Nov 18, 2023

  • use the provided callbackUrl instead of always going to the default static callbackUrl
  • add required scope to DiscordRouter — providing no scopes gives back an error, while providing at least one scope will always return identify scope together with the specified scopes
  • remove unused scope property in DiscordCallbackBody
  • add useful links to Discord Readme

* add required scope to DiscordRouter
* remove unsued scope property in DiscordCallbackBody
* add useful links to Discord Readme
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants