Correctly handle mobile menu closing

Fixes #375
varianter · Aug 23, 2023 · 977b6f6 · 977b6f6
1 parent 1dc7d48
commit 977b6f6
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src/components/page-header/index.tsx b/src/components/page-header/index.tsx
@@ -32,12 +32,10 @@ export default function PageHeader({
     closeRef,
     isNotHamburgerMode,
   );
-
-  const internalOnChangeVisible = () => {
-    const newVisible = !isMenuVisible;
-    onVisibleChange?.(newVisible);
-    setMenuVisible(newVisible);
-  };
+
+  useEffect(() => {
+    onVisibleChange?.(isMenuVisible);
+  }, [isMenuVisible, onVisibleChange]);
 
   const LogoWrapper = homepage ? 'h1' : 'div';
 
@@ -69,7 +67,7 @@ export default function PageHeader({
             aria-labelledby="menu-label"
             aria-expanded={isMenuVisible}
             aria-controls="menu-id"
-            onClick={() => internalOnChangeVisible()}
+            onClick={() => setMenuVisible(!isMenuVisible)}
           >
             <div
               className={and(