v3 - show salary for selected location, degree and examination year (web) #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mathiazom
changed the title
anemne
reviewed
Sep 12, 2024
anemne
reviewed
Sep 12, 2024
anemne
reviewed
Sep 12, 2024
| @@ -31,5 +38,6 @@ export interface CompensationsPage { | |||
| page: string; | |||
| slug: Slug; | |||
| benefitsByLocation: BenefitsByLocation[]; | |||
| salaries: SalariesByLocation[]; | |||
There was a problem hiding this comment.
I see we're doing salaries here, but benefitsByLocation above. Let's do either or
There was a problem hiding this comment.
That requires a breaking schema change, do we want to do it in this PR?
There was a problem hiding this comment.
No not at all. We can do it in a cleanup?
christinaroise
approved these changes
Sep 12, 2024
mathiazom
force-pushed
the
feat/v3-salary-in-web-calculator
branch
from
ee4913e
to
692879e
Compare
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further explanation is found here: #616
Replaces the hardcoded payscale with the location-based salary from Sanity.
Visual Overview (Image/Video)
No visual changes
Checklist
Please ensure that you’ve completed the following checkpoints before submitting your pull request: