vmod-var: check name for NULL in global_get

Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>
varnish · Nov 20, 2021 · c86bfd0 · c86bfd0
1 parent fe41c48
commit c86bfd0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/tests/var/test02.vtc b/src/tests/var/test02.vtc
@@ -14,6 +14,10 @@ varnish v1 -vcl+backend {
 		var.global_set("bar", "altered_barval");
 	}
 
+	sub vcl_recv {
+		var.global_get(req.http.NULL);
+	}
+
 	sub vcl_deliver {
 		set resp.http.x-foo = var.global_get("foo");
 		set resp.http.x-bar = var.global_get("bar");

diff --git a/src/vmod_var.c b/src/vmod_var.c
@@ -321,6 +321,9 @@ vmod_global_get(const struct vrt_ctx *ctx, VCL_STRING name)
 	struct var *v;
 	const char *r = NULL;
 
+	if (!name)
+		return (NULL);
+
 	AZ(pthread_mutex_lock(&var_list_mtx));
 	VTAILQ_FOREACH(v, &global_vars, list) {
 		CHECK_OBJ_NOTNULL(v, VAR_MAGIC);