Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment attachment (pc+mobile/light+dark themes supported) #1065

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Comment attachment (pc+mobile/light+dark themes supported) #1065

wants to merge 3 commits into from

Conversation

Holovin
Copy link
Contributor

@Holovin Holovin commented Mar 15, 2023

На базе: #975

Добавлено:

  1. ПК + мобильная версия
  2. ДиЗаЙн (почти выглядит так: https://t.me/vas3k_club_dev/15346)
  3. поддержал noscript версию (если выключен js то будет старая форма как была до). Свойство inline-template нужно потому что иначе vue игнорирует noscript и рендерит его в dom (Allow <noscript> in Vue templates for SSR usage vuejs/vue#8996)

@Holovin Holovin marked this pull request as ready for review March 15, 2023 16:06
@Holovin Holovin requested a review from vas3k as a code owner March 15, 2023 16:06
@igoose1
Copy link
Contributor

igoose1 commented Mar 24, 2023

Для больших экранов:
IMG_20230324_180551_185

Для мелких типо телефона:
IMG_20230324_180554_017

@bel0v
Copy link

bel0v commented Apr 10, 2023

Привет! Я совсем проебался — спасибо огромное, что подхватил ❤️
Предложение: как насчёт оставить "подписаться на комментарии" там же, где оно и было? Примерно так:
Screenshot 2023-04-10 at 15 41 17
Screenshot 2023-04-10 at 15 35 12

@bel0v bel0v mentioned this pull request Jul 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vas3k vas3k Awaiting requested review from vas3k vas3k is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Holovin @igoose1 @bel0v