-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add motor info to QNexuswidget #1088
base: master
Are you sure you want to change the base?
Conversation
Please rebase your work on current master that includes #1087 |
d8d93ba
to
55ae83c
Compare
Some comments: PyMca is used at other facilities than the ESRF and former ESRF files did not look like current ones. I would aim at using something similar to the function getPositionersGroup(h5file, path) in PyMca5.PyMcaCore.NexusTools.py That would make the use of the new feature not restricted to ESRF. For instance, A getStartingPositionersGroup in PyMca5.PyMcaCore.NexusTools.py seems to me more appropriate. It could use your hard-coded specific call and default to getPositionersGroup if nothing found. That would imply that if one positioner is an array of positions, the first position is used as starting point to allow the use of get_motor_positions. |
I tried to address your suggestions. Is there anything else to be done? |
It assumes they are either in: | ||
|
||
- NXentry/NXinstrument/positioners_start or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It assumes they are either in: | |
- NXentry/NXinstrument/positioners_start or | |
This method assumes the positioner group is NXentry/NXinstrument/positioners_start. |
Needs #1087 first