Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add motor info to QNexuswidget #1088

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

mspito
Copy link

@mspito mspito commented Aug 14, 2024

Needs #1087 first

Screenshot from 2024-08-14 16-15-52

@vasole
Copy link
Owner

vasole commented Aug 14, 2024

Please rebase your work on current master that includes #1087

@woutdenolf woutdenolf marked this pull request as ready for review August 14, 2024 16:23
@vasole
Copy link
Owner

vasole commented Aug 14, 2024

Some comments:

PyMca is used at other facilities than the ESRF and former ESRF files did not look like current ones.
I find nxpositioners = nxentry.get("instrument/positioners_start", None) very ESRF-centric and restrictive.

I would aim at using something similar to the function getPositionersGroup(h5file, path) in PyMca5.PyMcaCore.NexusTools.py That would make the use of the new feature not restricted to ESRF. For instance, A getStartingPositionersGroup in PyMca5.PyMcaCore.NexusTools.py seems to me more appropriate. It could use your hard-coded specific call and default to getPositionersGroup if nothing found. That would imply that if one positioner is an array of positions, the first position is used as starting point to allow the use of get_motor_positions.

@mspito
Copy link
Author

mspito commented Oct 14, 2024

I tried to address your suggestions. Is there anything else to be done?

Comment on lines +518 to +520
It assumes they are either in:

- NXentry/NXinstrument/positioners_start or
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It assumes they are either in:
- NXentry/NXinstrument/positioners_start or
This method assumes the positioner group is NXentry/NXinstrument/positioners_start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants