Run sweeper unconditionally on acc test runs and add CI Makefile target #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelnano
deleted the
ddelnano/ensure-sweeper-is-run-on-every-acc-test-run
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Run sweeper unconditionally on acc test runs and add CI Makefile target
This change is the final step needed to get master builds stable for #264. Future work will be done to surface these build statuses, but for now having CI running nightly is a great first step. The other change bundled with opting the
TestAccXenorchestraVm_addVifAndRemoveViftest into waiting for the VM's network interface to have an IP, which sped up the given test case.Testing done: Jenkins build has been stable with these changes