Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@signpdf/placeholder-pdf-lib #203

Merged
merged 8 commits into from
Nov 21, 2023
Merged

@signpdf/placeholder-pdf-lib #203

merged 8 commits into from
Nov 21, 2023

Conversation

vbuch
Copy link
Owner

@vbuch vbuch commented Nov 8, 2023 •
edited
Loading

@vbuch vbuch linked an issue Nov 8, 2023 that may be closed by this pull request
plainAddPlaceholder breaks the PDF file with existing annotations #198
Open
@vbuch vbuch removed a link to an issue Nov 8, 2023
plainAddPlaceholder breaks the PDF file with existing annotations #198
Open
@vbuch vbuch marked this pull request as draft November 8, 2023 11:03
@vbuch vbuch removed the draft label Nov 8, 2023
@vbuch vbuch force-pushed the feature/placeholder-pdf-lib branch from bda492f to b05135f Compare November 13, 2023 10:26
@vbuch vbuch changed the base branch from feature/findByteRange to develop November 13, 2023 10:27
@vbuch vbuch force-pushed the feature/placeholder-pdf-lib branch 2 times, most recently from dfe9acc to 2299656 Compare November 13, 2023 10:47
@coveralls
Copy link

coveralls commented Nov 13, 2023 •
edited
Loading

Coverage Status

coverage: 99.584% (+0.04%) from 99.545%
when pulling 82dc13a on feature/placeholder-pdf-lib
into a67f032 on develop.

@vbuch vbuch force-pushed the feature/placeholder-pdf-lib branch 6 times, most recently from 3612816 to 74152db Compare November 14, 2023 14:56
@vbuch vbuch marked this pull request as ready for review November 14, 2023 15:02
@vbuch vbuch changed the title Draft: @signpdf/placeholder-pdf-lib @signpdf/placeholder-pdf-lib Nov 14, 2023
@samaleksov
Copy link
Collaborator

LGTM!

Valeri Buchinski and others added 7 commits November 21, 2023 12:08
🔥 [placeholder-pdfkit010] Remove duplicate test
4fa70a8
@vbuch
💩👷 [placeholder-pdf-lib] Prepare for the package
d152b33
@vbuch @Hopding
✨💩 [placeholder-pdf-lib] Initial implementation
b4a595f 
based on Hopding's examples Hopding/pdf-lib#112 (comment)

Co-authored-by: Hopding <andrew.dillon.j@gmail.com>
✅ [placeholder-pdf-lib] Test
639290c
✨ [placeholder-pdf-lib]
9e00c37 
* Use pdf-lib 1.17 types;
* Use the newly introduced FLAG enums;
* Reuse existing AcroForm (refs #198);
* Reuse existing Annots (refs #198);
* Fix mistaken signature length;
@vbuch
📦 [placeholder-pdf-lib]
3199117
@vbuch
✨ [examples] placeholder-pdf-lib
68890a8
@vbuch vbuch force-pushed the feature/placeholder-pdf-lib branch 3 times, most recently from 403804e to 3a37c51 Compare November 21, 2023 10:25
@vbuch vbuch force-pushed the feature/placeholder-pdf-lib branch from 3a37c51 to 82dc13a Compare November 21, 2023 14:20
@vbuch vbuch merged commit 5855e24 into develop Nov 21, 2023
9 checks passed
@vbuch vbuch deleted the feature/placeholder-pdf-lib branch November 21, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MindFreeze MindFreeze MindFreeze approved these changes

@samaleksov samaleksov samaleksov approved these changes

@ivatrifonova ivatrifonova ivatrifonova approved these changes

@maldimirov maldimirov Awaiting requested review from maldimirov

Assignees
No one assigned
Labels
packages/placeholder-pdf-lib pdf-lib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vbuch @coveralls @samaleksov @MindFreeze @ivatrifonova