Revert unnecesarry specification of PodName

vdaas · Feb 13, 2024 · 98e60c8 · 98e60c8
1 parent cb13cb5
commit 98e60c8
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/hack/benchmark/internal/starter/agent/core/ngt/option.go b/hack/benchmark/internal/starter/agent/core/ngt/option.go
@@ -58,8 +58,6 @@ var defaultOptions = []Option{
 			Enabled: false,
 		},
 		NGT: &iconfig.NGT{
-			PodName:            "vald-agent-ngt-0",
-			PodNamespace:       "default",
 			Dimension:          0,
 			DistanceType:       "unknown",
 			ObjectType:         "unknown",

diff --git a/pkg/agent/core/ngt/service/ngt.go b/pkg/agent/core/ngt/service/ngt.go
@@ -169,7 +169,7 @@ const (
 )
 
 func New(cfg *config.NGT, opts ...Option) (nn NGT, err error) {
-	if cfg.PodName == "" {
+	if cfg.PodName == "" && cfg.EnableExportIndexInfoToK8s {
 		return nil, errors.New("pod_name is empty. this must be set either from environment variable or from config file")
 	}
 	n := &ngt{

diff --git a/pkg/agent/core/ngt/service/ngt_test.go b/pkg/agent/core/ngt/service/ngt_test.go
@@ -64,7 +64,6 @@ var defaultConfig = config.NGT{
 	},
 	BrokenIndexHistoryLimit: 1,
 	ErrorBufferLimit:        100,
-	PodName:                 "vald-agent-ngt-test",
 }
 
 type index struct {