Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor grpc/status.withDetails function for performance #2664

Refactor grpc/status.withDetails function for performance

7bd7d23
Select commit
Loading
Failed to load commit list.
Merged

Refactor grpc/status.withDetails function for performance #2664

Refactor grpc/status.withDetails function for performance
7bd7d23
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 2, 2024 in 1s

23.99% (-0.31%) compared to 51283dc

View this Pull Request on Codecov

23.99% (-0.31%) compared to 51283dc

Details

Codecov Report

Attention: Patch coverage is 13.37209% with 149 lines in your changes missing coverage. Please review.

Project coverage is 23.99%. Comparing base (51283dc) to head (7bd7d23).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/net/grpc/status/status.go 12.98% 132 Missing and 2 partials ⚠️
internal/os/hostname.go 16.66% 14 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2664      +/-   ##
==========================================
- Coverage   24.29%   23.99%   -0.31%     
==========================================
  Files         537      539       +2     
  Lines       46950    47179     +229     
==========================================
- Hits        11408    11322      -86     
- Misses      34764    35088     +324     
+ Partials      778      769       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.