Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add go1.23 on ubuntu tests #930

Merged
merged 2 commits into from
Dec 27, 2024
Merged

add go1.23 on ubuntu tests #930

merged 2 commits into from
Dec 27, 2024

Conversation

libotony
Copy link
Member

Description

Add go1.23 on Ubuntu tests and set Makefile to test minimum go version to go1.22.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@libotony libotony requested a review from a team as a code owner December 26, 2024 06:02
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.94%. Comparing base (1557868) to head (c281bfe).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
- Coverage   60.94%   60.94%   -0.01%     
==========================================
  Files         220      220              
  Lines       23431    23431              
==========================================
- Hits        14281    14279       -2     
- Misses       7984     7985       +1     
- Partials     1166     1167       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@libotony libotony merged commit ba7ff3f into master Dec 27, 2024
16 checks passed
@libotony libotony deleted the tony/update-ci branch December 27, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants