Introducing base fee + hard fork logic #933
Draft
+2,801
−745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paologalligit
force-pushed
the
feat/base-fee
branch
from
6218766 to
70c01ce
Compare
paologalligit
force-pushed
the
feat/typed-tx
branch
from
1ca93ca to
3deb860
Compare
paologalligit
force-pushed
the
feat/base-fee
branch
from
70c01ce to
4e7a99c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/galactica #933 +/- ##
====================================================
Coverage ? 61.11%
====================================================
Files ? 225
Lines ? 23937
Branches ? 0
====================================================
Hits ? 14628
Misses ? 8135
Partials ? 1174 ☔ View full report in Codecov by Sentry. |
paologalligit
changed the base branch from
feat/typed-tx
to
release/galactica
…using the optional rlp tag
paologalligit
force-pushed
the
feat/base-fee
branch
from
44c6966 to
a8fe27f
Compare
| @@ -233,7 +233,7 @@ func createOneClausePerTx(signerPK *ecdsa.PrivateKey, thorChain *testchain.Chain | |||
| for gasUsed < 9_500_000 { | |||
| toAddr := datagen.RandAddress() | |||
| cla := tx.NewClause(&toAddr).WithValue(big.NewInt(10000)) | |||
| transaction := new(tx.Builder). | |||
| transaction, _ := tx.NewTxBuilder(tx.LegacyTxType). | |||
There was a problem hiding this comment.
should we add dynTx in that phase ?
| assert.True(t, b.header.COM()) | ||
| } | ||
|
|
||
| func TestBuilder_BaseFee(t *testing.T) { |
There was a problem hiding this comment.
I suppose we should add tests for new fields too as builder will be able to build both new and old tx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is introducing a new field called
BaseFee. This is included in the block's header and fixes the gas threshold a tx must have to be included in the block.GH-Issue
Type of change
Please delete options that are not relevant.
Checklist: