Implement new vechain sdk #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: remove connex and init signer within dappkit * chore(deps): remove connex * fix: gha syntax error * chore(deps): remove connex * fix: tests * fix: build errors * revert: add sync2 back int * fix: tests * refactor: yarn, e2e and eslint (#311) * refactor: yarn, e2e and eslint * fix(GHA): install before install:all * fix(GHA): install before install:all * fix(extension): bug in extension * fix(extension): bug in extension * fix: update cucumber * fix: run stop preview after e2e * fix: lint errors * fix: sync errors * fix: sync2 not connecting * fix: sync2 txs broken * fix: tests * fix: tests * fix: yarn * fix: yarn workspaces * fix: missing declarations in test * fix: missing declarations in test * fix: missing declarations in test * fix: missing declarations in test * fix: dapp-kit-react tsx * fix: add exports to package.json * fix: ignore cucumber in examples * fix: set type to module * fix: package.jsons * fix: add type module * fix: package.jsons * fix: package.jsons * fix: fix angular * chore: documenation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -20,5 +20,5 @@ | |||
| '..', | |||
| 'veworld-dist.zip', | |||
| ); | |||
| await asyncExec(`unzip ${zipPath} -d ${distPath}`); | |||
| await asyncExec(`unzip -o ${zipPath}`); | |||
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 2 months ago
To fix the problem, we should avoid constructing the shell command as a single string that the shell interprets. Instead, we should use execFile or execFileSync to pass the command and its arguments separately. This approach ensures that the file path is treated as a literal argument and not subject to shell interpretation.
Specifically, we will:
- Replace the use of
execwithexecFile. - Pass the command (
unzip) and its arguments (-oand the file path) as separate parameters toexecFile.
Suggested changeset
1
tests/e2e/src/config/hooks/ExtensionHook.ts
| @@ -3,6 +3,6 @@ | ||
| import * as util from 'node:util'; | ||
| import { exec } from 'node:child_process'; | ||
| import { execFile } from 'node:child_process'; | ||
| import { BeforeAll } from '@cucumber/cucumber'; | ||
|
|
||
| const asyncExec = util.promisify(exec); | ||
| const asyncExecFile = util.promisify(execFile); | ||
|
|
||
| @@ -22,3 +22,3 @@ | ||
| ); | ||
| await asyncExec(`unzip -o ${zipPath}`); | ||
| await asyncExecFile('unzip', ['-o', zipPath]); | ||
| }); |
Copilot is powered by AI and may make mistakes. Always verify output.
fabiorigam
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.