Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reloading of config for aggregator #281

Closed
sinacek opened this issue Feb 14, 2023 · 6 comments
Closed

Enable reloading of config for aggregator #281

sinacek opened this issue Feb 14, 2023 · 6 comments

Comments

@sinacek
Copy link

sinacek commented Feb 14, 2023

Enable reloading of config for aggregator when config file is changed without restart of pod.

Notes:

@jszwedko
Copy link
Member

Hey @sinacek !

Would you be able to provide a bit more detail about what you are trying to accomplish? Is it that you want to use https://github.com/jimmidyson/configmap-reload with Vector to reload when the config map changes? If so, it should work once that tool supports sending SIGHUPs, which seems to be on its roadmap.

If that's not what you want, could you provide a bit more detail about your use-case?

@sinacek
Copy link
Author

sinacek commented Mar 17, 2023

Hi @jszwedko , that is exactly how you described. Roadmap of which project do you mean?

@jszwedko
Copy link
Member

Hi @jszwedko , that is exactly how you described. Roadmap of which project do you mean?

The roadmap of the https://github.com/jimmidyson/configmap-reload project. It looks like they aim to support sending SIGHUPs in the future which means it'll just work with Vector. Assuming that is what you want, I think we can close this issue and just wait for them to add it (jimmidyson/configmap-reload#23).

@sinacek
Copy link
Author

sinacek commented Mar 17, 2023

That issue is 5 years old, so i'm not sure if he has plan to implement it. Do you have on road map add endpoint to reload as it has prometheus?

@jszwedko
Copy link
Member

We don't have plans for that at the moment, but if it'd be useful for you would you want to open a feature request on the Vector repository describing what you would need? https://github.com/vectordotdev/vector/issues/new?assignees=&labels=type%3A+feature&template=feature.yml

@sinacek
Copy link
Author

sinacek commented Mar 17, 2023

I find that similar issue is already exists, so I send comment there vectordotdev/vector#541

@sinacek sinacek closed this as completed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants