Skip to content

Commit

Permalink
feat(tc): simplify tc api
Browse files Browse the repository at this point in the history
  • Loading branch information
Kerry Perret committed Jan 23, 2021
1 parent 625318b commit 177cd33
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
10 changes: 5 additions & 5 deletions Vp.FSharp.Sql/Transaction.fs
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
[<RequireQualifiedAccess>]
module Vp.FSharp.Sql.Transaction

open System.Data
open System.Threading
open System.Data.Common
open System.Transactions
open System.Threading.Tasks

open Vp.FSharp.Sql.Helpers
Expand All @@ -14,7 +14,7 @@ let DefaultIsolationLevel = IsolationLevel.ReadCommitted

let commit cancellationToken isolationLevel
(connection: #DbConnection)
(beginTransaction: #DbConnection -> 'IsolationLevel -> CancellationToken -> ValueTask<#DbTransaction>)
(beginTransaction: #DbConnection -> IsolationLevel -> CancellationToken -> ValueTask<#DbTransaction>)
(body: #DbConnection -> #DbTransaction -> Async<'Output>)=
async {
let wasClosed = DbConnection.isClosed connection
Expand All @@ -31,7 +31,7 @@ let commit cancellationToken isolationLevel

let notCommit cancellationToken isolationLevel
(connection: #DbConnection)
(beginTransaction: #DbConnection -> 'IsolationLevel -> CancellationToken -> ValueTask<#DbTransaction>)
(beginTransaction: #DbConnection -> IsolationLevel -> CancellationToken -> ValueTask<#DbTransaction>)
(body: #DbConnection -> #DbTransaction -> Async<'Output>) =
async {
let wasClosed = DbConnection.isClosed connection
Expand All @@ -47,7 +47,7 @@ let notCommit cancellationToken isolationLevel

let commitOnSome cancellationToken isolationLevel
(connection: #DbConnection)
(beginTransaction: #DbConnection -> 'IsolationLevel -> CancellationToken -> ValueTask<#DbTransaction>)
(beginTransaction: #DbConnection -> IsolationLevel -> CancellationToken -> ValueTask<#DbTransaction>)
(body: #DbConnection -> #DbTransaction -> Async<'Output option>) =
async {
let wasClosed = DbConnection.isClosed connection
Expand All @@ -67,7 +67,7 @@ let commitOnSome cancellationToken isolationLevel

let commitOnOk cancellationToken isolationLevel
(connection: #DbConnection)
(beginTransaction: #DbConnection -> 'IsolationLevel -> CancellationToken -> ValueTask<#DbTransaction>)
(beginTransaction: #DbConnection -> IsolationLevel -> CancellationToken -> ValueTask<#DbTransaction>)
(body: #DbConnection -> #DbTransaction -> Async<Result<'Ok, 'Error>>) =
async {
let wasClosed = DbConnection.isClosed connection
Expand Down
2 changes: 1 addition & 1 deletion Vp.FSharp.Sql/TransactionScope.fs
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
module Vp.FSharp.Sql.TransactionScope

open System
open System.Data.Common
open System.Threading
open System.Data.Common
open System.Transactions

open Vp.FSharp.Sql.Helpers
Expand Down
4 changes: 2 additions & 2 deletions Vp.FSharp.Sql/Types.fs
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

open System
open System.Data
open System.Data.Common
open System.Threading
open System.Data.Common
open System.Threading.Tasks

open Vp.FSharp.Sql.Helpers
Expand Down Expand Up @@ -117,7 +117,7 @@ type SqlDependencies<'DbConnection, 'DbCommand, 'DbParameter, 'DbDataReader,
and 'DbTransaction :> DbTransaction> =
{ CreateCommand: 'DbConnection -> 'DbCommand
SetCommandTransaction: 'DbCommand -> 'DbTransaction -> unit
BeginTransactionAsync: 'DbConnection -> 'DbTransactionIsolationLevel -> CancellationToken -> ValueTask<'DbTransaction>
BeginTransactionAsync: 'DbConnection -> IsolationLevel -> CancellationToken -> ValueTask<'DbTransaction>
ExecuteReaderAsync: 'DbCommand -> CancellationToken -> Task<'DbDataReader>
DbValueToParameter: string -> 'DbType -> 'DbParameter }

Expand Down

0 comments on commit 177cd33

Please sign in to comment.