We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firstly, in connection/*_spec.rb setting up a stubbed response with:
connection/*_spec.rb
ups-ruby/spec/ups/connection/ship_spec.rb
Lines 21 to 28 in 77175ae
just matches on the request URL path, then returns a canned response. The specs just check against what was in the canned response.
In effect they're only testing the response parsing, instead of the request. Is this ok?
Second, the XML schema validation:
ups-ruby/spec/ups/builders/ship_confirm_builder_spec.rb
Lines 20 to 22 in 77175ae
appears to me to do nothing. Mutilating the XML that is generated in the builders results in no failure. How is this supposed to work?
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Firstly, in
connection/*_spec.rb
setting up a stubbed response with:ups-ruby/spec/ups/connection/ship_spec.rb
Lines 21 to 28 in 77175ae
just matches on the request URL path, then returns a canned response. The specs just check against what was in the canned response.
In effect they're only testing the response parsing, instead of the request. Is this ok?
Second, the XML schema validation:
ups-ruby/spec/ups/builders/ship_confirm_builder_spec.rb
Lines 20 to 22 in 77175ae
appears to me to do nothing. Mutilating the XML that is generated in the builders results in no failure. How is this supposed to work?
The text was updated successfully, but these errors were encountered: