BaseAlignment only draws when pixel is set (bug fix).

veg · Mar 19, 2020 · 97b241f · 97b241f
1 parent 156309a
commit 97b241f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "alignment.js",
-  "version": "0.2.2",
+  "version": "0.2.3",
   "main": "library.js",
   "license": "MIT",
   "dependencies": {

diff --git a/src/components/BaseAlignment.jsx b/src/components/BaseAlignment.jsx
@@ -24,7 +24,10 @@ class BaseAlignment extends Component {
     }
   }
   componentDidUpdate() {
-    this.draw(this.props.x_pixel || 0, this.props.y_pixel || 0);
+    const { x_pixel, y_pixel } = this.props;
+    if (x_pixel != undefined || y_pixel != undefined) {
+      this.draw(x_pixel || 0, y_pixel || 0);
+    }
   }
   draw(x_pixel, y_pixel) {
     if (this.props.disableVerticalScrolling) y_pixel = 0;

diff --git a/src/components/SiteAxis.jsx b/src/components/SiteAxis.jsx
@@ -30,6 +30,9 @@ class SiteAxis extends Component {
         $("#alignmentjs-axis-div").scrollLeft(e.detail.x_pixel);
       });
   }
+  componentDidUpdate(nextProps) {
+    $("#alignmentjs-axis-div").scrollLeft(this.props.x_pixel);
+  }
   handleWheel(e) {
     e.preventDefault();
     this.props.scroll_broadcaster.handleWheel(e, this.props.sender);