Correct the method-based syntax for a few more gallery examples #3005
Conversation
| @@ -69,7 +69,7 @@ | |||
| alt.Chart(source).mark_point(filled=True, opacity=1, size=100).encode( | |||
| alt.X('x:O').axis(None), | |||
| alt.Y('animal:O').axis(None), | |||
| alt.Row('country:N').header(title=''), | |||
| alt.Row('country:N').title(''), | |||
There was a problem hiding this comment.
| alt.Row('country:N').title(''), | |
| alt.Row('country:N').title(None), |
I prefer None over ''.
There was a problem hiding this comment.
This is interesting. I think None is more semantically correct but '' is more convenient to type and I remember that when I started to use Altair a few years ago, there was some context where None didn't work, but '' did. It is possible that I was just doing something wrong back then, but I will see if I can find it again.
There was a problem hiding this comment.
Might be, I can remember something similar. But I would consider that as a limitation of Vega-Lite at that moment.
| @@ -11,7 +11,7 @@ | |||
| source = data.seattle_weather() | |||
|
|
|||
| base = alt.Chart(source).encode( | |||
| alt.X('month(date):T').axis(title=None) | |||
| alt.X('month(date):T').title('') | |||
There was a problem hiding this comment.
| alt.X('month(date):T').title('') | |
| alt.X('month(date):T').title(None) |
Or there is another reason why you opt for ''?
joelostblom
force-pushed
the
gallery-examples
branch
from
0259208 to
3b9ac58
Compare
joelostblom
force-pushed
the
gallery-examples
branch
from
3b9ac58 to
9602812
Compare
|
@mattijn I forgot about this for some while, but I noticed it now and went ahead with your suggestion of using |
No description provided.