chore(ruff): Update to `0.9.0` #3766

dangotbanned · 2025-01-10T11:32:52Z

Resolves #3765

Notes

(cc9aa84) should be enough to pass CI
Going through the past few releases to
- Update remapped rule codes (e.g. TCH -> TC)
- Review what we have selected as preview
- Port over some redundancies I identified in (vega/vega-datasets@02286f3)
Run the ruff tables only through taplo (92f5947)
- https://marketplace.visualstudio.com/items?itemName=tamasfe.even-better-toml
- https://taplo.tamasfe.dev/configuration/formatter-options.html

Running `ruff format` on `>=0.9.0` https://astral.sh/blog/ruff-v0.9.0#the-ruff-2025-style-guide ]

https://docs.astral.sh/ruff/configuration/

- `E` rules here are not triggered on the current codebase - `B905` seems to be accounting for `tool.ruff.target-version = "py39"`

- (https://github.com/astral-sh/ruff/releases/tag/0.8.0) - `RUF022` stablized - `TCH` -> `TC`

Using an adaptation of (https://github.com/vega/vega-datasets/blob/c53c1beaa4ea71e93f612d7d88c12f15c2c64c84/taplo.toml) ```toml #:schema taplo://taplo.toml [formatting] align_entries = true allowed_blank_lines = 1 column_width = 88 compact_entries = false crlf = false indent_string = " " reorder_arrays = true reorder_inline_tables = true reorder_keys = true ```

- Includes resolving (#3766) warnings on new code

Related: - https://github.com/vega/altair/actions/runs/12810882256/job/35718940621?pr=3631 - #3766 - astral-sh/ruff#15201 (comment)

dangotbanned added 2 commits January 10, 2025 11:15

chore(ruff): Ignore TC008 false positives

e49fac5

astral-sh/ruff#15201 (comment)

style(ruff): Apply 2025 format style

cc9aa84

Running `ruff format` on `>=0.9.0` https://astral.sh/blog/ruff-v0.9.0#the-ruff-2025-style-guide ]

dangotbanned added the maintenance label Jan 10, 2025

dangotbanned added 4 commits January 10, 2025 12:27

ci(ruff): Remove default format settings

406d544

https://docs.astral.sh/ruff/configuration/

ci(ruff): Remove unused ignores

2645a10

- `E` rules here are not triggered on the current codebase - `B905` seems to be accounting for `tool.ruff.target-version = "py39"`

ci(ruff): Apply 0.8.0 updates

947eb50

- (https://github.com/astral-sh/ruff/releases/tag/0.8.0) - `RUF022` stablized - `TCH` -> `TC`

dangotbanned marked this pull request as ready for review January 10, 2025 14:18

dangotbanned enabled auto-merge (squash) January 10, 2025 14:18

dangotbanned merged commit 8a6f65c into main Jan 10, 2025
26 checks passed

dangotbanned deleted the bump-ruff-0.9.0 branch January 10, 2025 14:29

dangotbanned added a commit that referenced this pull request Jan 12, 2025

Merge remote-tracking branch 'upstream/main' into vega-datasets

7e7b303

- Includes resolving (#3766) warnings on new code

dangotbanned added a commit that referenced this pull request Jan 16, 2025

chore(ruff): Fix 0.9.2 lints

a6b3911

Related: - https://github.com/vega/altair/actions/runs/12810882256/job/35718940621?pr=3631 - #3766 - astral-sh/ruff#15201 (comment)

This was referenced Jan 16, 2025

chore(ruff): Fix 0.9.2 lints #3771

Merged

build: Migrate from hatch to uv #3723

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ruff): Update to `0.9.0` #3766

chore(ruff): Update to `0.9.0` #3766

dangotbanned commented Jan 10, 2025 •

edited

Loading

chore(ruff): Update to 0.9.0 #3766

chore(ruff): Update to 0.9.0 #3766

Conversation

dangotbanned commented Jan 10, 2025 • edited Loading

Notes

chore(ruff): Update to `0.9.0` #3766

chore(ruff): Update to `0.9.0` #3766

dangotbanned commented Jan 10, 2025 •

edited

Loading