Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fee table labels and visual hierarchy, add maker rebate column #6707

Closed
1 of 4 tasks
barnabee opened this issue Jul 18, 2024 · 1 comment · Fixed by #6736
Closed
1 of 4 tasks

Improve fee table labels and visual hierarchy, add maker rebate column #6707

barnabee opened this issue Jul 18, 2024 · 1 comment · Fixed by #6736
Assignees
Labels
branch-develop Work for the next planned release of frontend apps small-task

Comments

@barnabee
Copy link
Member

barnabee commented Jul 18, 2024

The columns in this fees table are not labelled in line with industry norms, and it's not clear that three of the columns are a breakdown of another column rather than separate fees:

Screenshot 2024-07-18 at 11 11 46

Labels should be updated as follows:

Total fee after discountTaker fee after discount
Total fee before discountTaker fee before discount

We need to make the fee components much more clearly a breakdown of the fee before discount, perhaps we can use larger fonts for the two total fees and a more muted colour for the fee components. If there was a way to make this hierarchy/breakdown even more clear, or even to hide the breakdown initially, that'd be good.

It would also be worth adding a maker rebate column which would need to show a range from the lowest (with maxed out discounts) to the highest (the maker fee component amount) rebate that a maker woudl receive.

This table needs to be redesigned when the new fee components in vegaprotocol/specs#2295 and the dynamic maker fee landhttps://github.com/vegaprotocol/specs/issues/2296 land, but the above should be good for now.

Acceptance Criteria

  • Change Total fee after discountTaker fee after discount and pin it to the far left
  • Change Total fee before discountTaker fee before discount and move it to be the second column
  • Other columns are unchanged to the right
  • Do something to emphasise those first two columns or de-emphasize the last three (brightness / size)
@barnabee barnabee changed the title Improve fee table labels Improve fee table labels and visual hierarchy, add maker rebate column Jul 18, 2024
@JonRay15
Copy link
Contributor

Personally I do not see this issue as high impact enough to justify doing it ahead of the fee mechanics changes. Can we consider this as part of those changes and redesign the page as part of that process?

@JonRay15 JonRay15 added small-task branch-develop Work for the next planned release of frontend apps and removed refine labels Jul 29, 2024
@JonRay15 JonRay15 moved this from New to Todo in Frontend Engineering Jul 29, 2024
@dexturr dexturr moved this from Todo to Review in Frontend Engineering Jul 31, 2024
@dexturr dexturr self-assigned this Jul 31, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Frontend Engineering Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-develop Work for the next planned release of frontend apps small-task
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants