Skip to content

Commit

Permalink
feat: apply feedback from review
Browse files Browse the repository at this point in the history
Co-authored-by: Jiajia-Cui <92106936+Jiajia-Cui@users.noreply.github.com>
  • Loading branch information
cdummett and Jiajia-Cui authored Mar 25, 2024
1 parent a7f4bc9 commit 05a9e6d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion protocol/0041-TSTK-target_stake.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ The above design ensures the `target_stake` of a market is unable to fluctuate d
- For a spot market, given a `scaling_factor=1` and non-zero asset decimals. The target stake should be set to the maximum total supplied stake over the previous `time_window`. (<a name="0041-TSTK-XXX" href="#0041-TSTK-XXX">0041-TSTK-XXX</a>)
- For a spot market, given a `scaling_factor<1` The target stake should be set to the product of the `scaling_factor` and the maximum total supplied stake over the previous `time_window`. (<a name="0041-TSTK-XXX" href="#0041-TSTK-XXX">0041-TSTK-XXX</a>)
- For a spot market, given a LP increases their commitment, the target stake should increase to reflect that change. (<a name="0041-TSTK-XXX" href="#0041-TSTK-XXX">0041-TSTK-XXX</a>)
- For a spot market, given a LP decreases their commitment, the target stake will not decrease to reflect that change un till end of the epoch when the reduction is processed and the rolling time window no longer includes the total stake prior to the commitment change.(<a name="0041-TSTK-XXX" href="#0041-TSTK-XXX">0041-TSTK-XXX</a>)
- For a spot market, given a LP decreases their commitment, the target stake will not decrease to reflect that change until end of the epoch when the reduction is processed and the rolling time window no longer includes the total stake prior to the commitment change.(<a name="0041-TSTK-XXX" href="#0041-TSTK-XXX">0041-TSTK-XXX</a>)
- For a spot market, change of `market.stake.target.scalingFactor` will immediately change the target stake. (<a name="0041-TSTK-XXX" href="#0041-TSTK-XXX">0041-TSTK-XXX</a>)
- For a spot market, an increase of `time_window` will immediately change the length of time window over which total stake is measured however new records will not be added hence the target stake will not immediately change (<a name="0041-TSTK-XXX" href="#0041-TSTK-XXX">0041-TSTK-XXX</a>)
- For a spot market, a decrease of `time_window` will immediately change the length of time window over which the total stake is measured and old records will be dropped hence the target stake will immediately change (<a name="0041-TSTK-XXX" href="#0041-TSTK-XXX">0041-TSTK-XXX</a>)
2 changes: 1 addition & 1 deletion protocol/0044-LIME-lp_mechanics.md
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ and in the case of spot markets into the network treasury for the asset (<a name
- If a liquidity provider with an active liquidity provision at the start of an epoch reduces their liquidity provision staked commitment during the epoch the initial committed level at the start of the epoch will remain in effect until the end of the epoch, at which point the protocol will attempt to reduce the bond to the new level. If the reduced level has been changed several times during an epoch, only the latest value will take effect (<a name="0044-LIME-019" href="#0044-LIME-019">0044-LIME-019</a>). For product spot (<a name="0044-LIME-0XX" href="#0044-LIME-0XX">0044-LIME-0XX</a>)
- If a liquidity provider with an active liquidity provision at the start of an epoch reduces their liquidity provision staked commitment during the epoch the initial committed level at the start of the epoch will remain in effect until the end of the epoch, at which point the protocol will attempt to reduce the bond to the new level. If the bond stake has been slashed to a level lower than the amendment, this slashed level will be retained (i.e. the protocol will not attempt to now increase the commitment) (<a name="0044-LIME-020" href="#0044-LIME-020">0044-LIME-020</a>). For product spot (<a name="0044-LIME-0XX" href="#0044-LIME-0XX">0044-LIME-0XX</a>)
- If a liquidity provider with an active liquidity provision at the start of an epoch amends the fee level associated to this commitment during the epoch, this change will only take effect at the end of the epoch. (<a name="0044-LIME-021" href="#0044-LIME-021">0044-LIME-021</a>). For product spot (<a name="0044-LIME-0XX" href="#0044-LIME-0XX">0044-LIME-0XX</a>)
- If a liquidity provider with an active liquidity provision at the start of an epoch increases their liquidity provision staked commitment during the epoch, the amended committed level will take affect immediately and the protocol will attempt to increase the bond to the new level if they do not have sufficient collateral in the settlement asset of the market to meet new commitment amount then the amendment will be rejected and old commitment amount is retained (<a name="0044-LIME-030" href="#0044-LIME-030">0044-LIME-030</a>). For product spot (<a name="0044-LIME-0XX" href="#0044-LIME-0XX">0044-LIME-0XX</a>)
- If a liquidity provider with an active liquidity provision at the start of an epoch increases their liquidity provision staked commitment during the epoch, the amended committed level will take affect immediately and the protocol will attempt to increase the bond to the new level, if they do not have sufficient collateral in the settlement asset of the market to meet new commitment amount then the amendment will be rejected and old commitment amount is retained (<a name="0044-LIME-030" href="#0044-LIME-030">0044-LIME-030</a>). For product spot (<a name="0044-LIME-0XX" href="#0044-LIME-0XX">0044-LIME-0XX</a>)
- If a liquidity provider with an active liquidity provision at the start of an epoch increases their liquidity provision staked commitment during the epoch, the amended committed level will take affect immediately and
- the protocol will increase the bond to the new level if they have sufficient collateral in the settlement asset of the market to meet new commitment amount (<a name="0044-LIME-031" href="#0044-LIME-031">0044-LIME-031</a>). For product spot (<a name="0044-LIME-0XX" href="#0044-LIME-0XX">0044-LIME-0XX</a>)
- at the end of the current epoch rewards / penalties are evaluated based on the balance of the bond account at start of epoch (<a name="0044-LIME-049" href="#0044-LIME-049">0044-LIME-049</a>). For product spot (<a name="0044-LIME-0XX" href="#0044-LIME-0XX">0044-LIME-0XX</a>)
Expand Down

0 comments on commit 05a9e6d

Please sign in to comment.