Skip to content

Commit

Permalink
feat: add acs for program update behaviour
Browse files Browse the repository at this point in the history
  • Loading branch information
cdummett committed Sep 18, 2024
1 parent e352ed3 commit be51a89
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 0 deletions.
3 changes: 3 additions & 0 deletions protocol/0083-RFPR-on_chain_referral_program.md
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,9 @@ The Estimate Fees API should now calculate the following additional information:
- `referralProgram.maxReferralRewardFactor` (<a name="0083-RFPR-042" href="#0083-RFPR-042">0083-RFPR-042</a>)
- `referralProgram.maxReferralDiscountFactor` (<a name="0083-RFPR-043" href="#0083-RFPR-043">0083-RFPR-043</a>)

1. Given a referral program is not active, if an `UpdateReferralProgram` is enacted in epoch `k`. The program should be active in `k+1` **AND** all parties that qualify for a tier in the new program should receive the relevant factors from the new programs tier. (<a name="0083-RFPR-056" href="#0083-RFPR-056">0083-RFPR-056</a>).
1. Given a referral program is active, if an `UpdateReferralProgram` is enacted in epoch `k`. The program should be updated in `k+1` **AND** all parties that qualify for a tier in the updated program should receive the relevant factors from the updated programs tier. (<a name="0083-RFPR-057" href="#0083-RFPR-057">0083-RFPR-057</a>).

### Referral set mechanics

#### Creating a referral set
Expand Down
3 changes: 3 additions & 0 deletions protocol/0084-VDPR-volume_discount_program.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,9 @@ The Trades API should now also expose the following additional information for e
- `volumeDiscountProgram.maxBenefitTiers` (<a name="0084-VDPR-015" href="#0084-VDPR-015">0084-VDPR-015</a>).
- `volumeDiscountProgram.maxVolumeDiscountFactor` (<a name="0084-VDPR-016" href="#0084-VDPR-016">0084-VDPR-016</a>).

1. Given a volume discount program program is not active, if an `UpdateVolumeDiscountProgram` is enacted in epoch `k`. The program should be active in `k+1` **AND** all parties that qualify for a tier in the new program should receive the relevant factors from the new programs tier. (<a name="0083-RFPR-019" href="#0083-RFPR-019">0083-RFPR-019</a>).
1. Given a volume discount program program is active, if an `UpdateVolumeDiscountProgram` is enacted in epoch `k`. The program should be updated in `k+1` **AND** all parties that qualify for a tier in the updated program should receive the relevant factors from the updated programs tier. (<a name="0083-RFPR-020" href="#0083-RFPR-020">0083-RFPR-020</a>).

### Setting benefit factors

1. At the start of an epoch, each parties `volume_discount_factors` are reevaluated and fixed for the epoch (<a name="0084-VDPR-012" href="#0084-VDPR-012">0084-VDPR-012</a>).
Expand Down
3 changes: 3 additions & 0 deletions protocol/0095-HVMR-high_volume_maker_rebate.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ Any APIs which report a party's rebate factor should adhere to this cap and retu
1. Updating any of the following network parameters whilst there is an active volume rebate program will not modify or cancel the active program in any way. The updated parameters will however be used to validate future volume rebate program proposals.
- `volumeRebateProgram.maxBenefitTiers` (<a name="0095-HVMR-012" href="#0095-HVMR-012">0095-HVMR-012</a>).

1. Given a volume discount program program is not active, if an `UpdateVolumeRebateProgram` is enacted in epoch `k`. The program should be active in `k+1` **AND** all parties that qualify for a tier in the new program should receive the relevant factors from the new programs tier. (<a name="0095-HVMR-040" href="#0095-HVMR-040">0095-HVMR-040</a>).
1. Given a volume discount program program is active, if an `UpdateVolumeRebateProgram` is enacted in epoch `k`. The program should be updated in `k+1` **AND** all parties that qualify for a tier in the updated program should receive the relevant factors from the updated programs tier. (<a name="0095-HVMR-041" href="#0095-HVMR-041">0095-HVMR-041</a>).

### Maker volume fraction

#### Contributing trades
Expand Down
11 changes: 11 additions & 0 deletions protocol/features.json
Original file line number Diff line number Diff line change
Expand Up @@ -853,6 +853,17 @@
"0080-SPOT-029"
]
},
"Program enactment fixes": {
"milestone": "genbutemple",
"acs": [
"0083-RFPR-056",
"0083-RFPR-057",
"0084-VDPR-019",
"0084-VDPR-020",
"0095-HVMR-040",
"0095-HVMR-041"
]
},
"Unknown": {
"milestone": "unknown",
"acs": []
Expand Down

0 comments on commit be51a89

Please sign in to comment.