Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and add more ACs for liquidation strategy #2070

Closed
gordsport opened this issue Nov 29, 2023 · 0 comments · Fixed by #2100
Closed

Review and add more ACs for liquidation strategy #2070

gordsport opened this issue Nov 29, 2023 · 0 comments · Fixed by #2100
Assignees

Comments

@gordsport
Copy link
Contributor

gordsport commented Nov 29, 2023

With the introuction of the [Liquidation improvements] Completely decouple MTM, margin checks and closeout trades spec changes and core implementation/fixes there is a need to review and add ACs as the testing of this feature commences.

There have been a number of issues found in Market Sim that maybe should be covered in tests.

We should also be adding an AC for a happy path whereby we verify all balances are correct via the APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants