Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Make relative return reward include losses #2238

Closed
3 tasks
JonRay15 opened this issue Apr 15, 2024 · 0 comments · Fixed by #2241
Closed
3 tasks

[Feature]: Make relative return reward include losses #2238

JonRay15 opened this issue Apr 15, 2024 · 0 comments · Fixed by #2241

Comments

@JonRay15
Copy link
Contributor

JonRay15 commented Apr 15, 2024

Feature Overview

In order to improve the current games functionality
We will look into these hopefully "quick fixes"
So that people find the games more engaging

Tasks

  • Adjust the relativeReturn reward type so that instead of disregarding any key with a loss we rank ALL eligible keys in terms of P&L and reward them. This would allow the game to account for the situation where the market turns and everyone is losing, but some are losing "better" than others.
    • For a pro rata game this would mean rewarding all eligible keys some amount
    • For a ranked game this would mean that keys in loss can still be in the ranking table

Feature test scenarios

Detailed scenarios that can be executed as feature tests to verify that the feature has been implemented as expected.

GIVEN (setup/context)
WHEN (action)
THEN (assertion) For example...
See here for more format information and examples.

Additional Details (optional)

Any additional information that provides context or gives information that will help us develop the feature.

@cdummett cdummett transferred this issue from vegaprotocol/vega Apr 15, 2024
@davidsiska-vega davidsiska-vega added this to the 🏛️ Colosseo I milestone Apr 17, 2024
@cdummett cdummett linked a pull request Apr 24, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this to Merged in Core Kanban Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants